Page MenuHomePhabricator

GEMentorshipAutomaticEligibility description is wrong
Closed, ResolvedPublic0.5 Estimated Story Points

Description

It's currently described as

Editors who meet all eligibility criteria are automatically enrolled as mentors

This reads to me like they become mentors without having to go to Special:EnrollAsMentor. What it actually means seems to be to give effect to the other two settings at https://en.wikipedia.org/wiki/Special:CommunityConfiguration/Mentorship.

It definitely needs to be redescribed, and ideally it would not be a separate checkbox at all but get set automatically if the days and edits fields are non-blank.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

I agree it can lead to confusion, what happens is that they get the "enrollasmentor" permission but they are not directly enrolled. Maybe just updating to are to can be. What do you think? cc @Urbanecm_WMF @KStoller-WMF

I agree this language is confusing. What do you think about the following description:

Editors who meet all eligibility criteria are automatically eligible to enroll as mentors

I'm also wondering if we should add help text to explain what it means if Mentorship is turned on, but this setting isn't checked?

Something like:

If this setting remains unchecked while Mentorship features are turned on, then potential mentors will be unable to enroll in Mentorship, and only Admins can add new Mentors via GrowthMentors.json.

Is that actually the correct explanation?

If this setting remains unchecked while Mentorship features are turned on, then potential mentors will be unable to enroll in Mentorship, and only Admins can add new Mentors via GrowthMentors.json.

Presumably should be "via Special:ManageMentors" instead.

If this checkbox needs to be there at all ("ideally it would not be a separate checkbox at all but get set automatically if the days and edits fields are non-blank") then your description is as good as any.

KStoller-WMF moved this task from Needs Discussion to Up Next on the Growth-Team board.

Change #1060119 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@master] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060119

Change #1060119 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060119

Change #1060136 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.16] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060136

Change #1060139 had a related patch set uploaded (by Michael Große; author: Michael Große):

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.17] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060139

KStoller-WMF set the point value for this task to 0.5.Aug 6 2024, 4:03 PM

Change #1060139 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.17] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060139

Change #1060136 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@wmf/1.43.0-wmf.16] fix(i18n): adjust broken mentorship eligibility copy

https://gerrit.wikimedia.org/r/1060136

Mentioned in SAL (#wikimedia-operations) [2024-08-06T20:47:48Z] <kindrobot@deploy1003> Started scap sync-world: Backport for [[gerrit:1060152|Promote dark mode for anons on various wikis - take 2 (T371070 T371084)]], [[gerrit:1060123|Enable NetworkSession extension for most wikis (T355267)]], [[gerrit:1060139|fix(i18n): adjust broken mentorship eligibility copy (T371775 T370318)]], [[gerrit:1060136|fix(i18n): adjust broken mentorship eligibility copy (T371775 T370318)]]

Mentioned in SAL (#wikimedia-operations) [2024-08-06T21:21:27Z] <kindrobot@deploy1003> toyofuku, ebernhardson, kindrobot, migr: Backport for [[gerrit:1060152|Promote dark mode for anons on various wikis - take 2 (T371070 T371084)]], [[gerrit:1060123|Enable NetworkSession extension for most wikis (T355267)]], [[gerrit:1060139|fix(i18n): adjust broken mentorship eligibility copy (T371775 T370318)]], [[gerrit:1060136|fix(i18n): adjust broken mentorship eligibility copy (T371775 T37031

Mentioned in SAL (#wikimedia-operations) [2024-08-06T21:34:53Z] <kindrobot@deploy1003> Finished scap: Backport for [[gerrit:1060152|Promote dark mode for anons on various wikis - take 2 (T371070 T371084)]], [[gerrit:1060123|Enable NetworkSession extension for most wikis (T355267)]], [[gerrit:1060139|fix(i18n): adjust broken mentorship eligibility copy (T371775 T370318)]], [[gerrit:1060136|fix(i18n): adjust broken mentorship eligibility copy (T371775 T370318)]] (duration: 47m 05s)

Etonkovidova subscribed.

Checked on wmf.18 - the new wording for eligible potential mentors and to clarify some effects of disabled mentorship on enrolling new mentors is in place:

Screen Shot 2024-08-15 at 4.42.53 PM.png (726×2 px, 178 KB)