Page MenuHomePhabricator
Create Task
Maniphest T343495

Phan failure on Linter with Call to undeclared method \Wikimedia\Rdbms\IDatabase::fieldExists
Closed, ResolvedPublic
Actions

Description

After https://gerrit.wikimedia.org/r/c/mediawiki/core/+/939777 phan does not see a DBConnRef in IndexPager::$mDb and reports in Linter:

includes/LintErrorsPager.php:136 PhanUndeclaredMethod Call to undeclared method \Wikimedia\Rdbms\IDatabase::fieldExists
includes/LintErrorsPager.php:154 PhanUndeclaredMethod Call to undeclared method \Wikimedia\Rdbms\IDatabase::fieldExists

(Global function wfGetDB returns DBConnRef, which implements IMaintainableDatabase::fieldExists, but that method is not in IDatabase)

Details

SubjectRepoBranchLines +/-
Use a maintenance database connection to call fieldExistsmediawiki/extensions/Lintermaster+5 -6
Customize query in gerrit

Event Timeline

Umherirrender created this task.Aug 3 2023, 11:44 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 3 2023, 11:44 PM
Daimona added a comment.Aug 3 2023, 11:52 PM

The mDb property was already documented as IDatabase before. I think this code in linter should obtain an IMaintainableDatabase separately.

gerritbot added a comment.Aug 4 2023, 9:56 AM

Change 945758 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Linter@master] Use a maintenance database connection to call fieldExists

https://gerrit.wikimedia.org/r/945758

gerritbot added a project: Patch-For-Review.Aug 4 2023, 9:56 AM
Umherirrender claimed this task.Aug 4 2023, 9:56 AM
Daimona closed this task as Resolved.Aug 4 2023, 12:43 PM
gerritbot added a comment.Aug 4 2023, 12:45 PM

Change 945758 merged by jenkins-bot:

[mediawiki/extensions/Linter@master] Use a maintenance database connection to call fieldExists

https://gerrit.wikimedia.org/r/945758

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 4 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 4 2023, 1:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL