Page MenuHomePhabricator

Update FunctionEvaluator to runnable when implementations are connected
Open, LowPublic

Description

Reproduce:

  • Go to a function that have no approved implementation but have unapproved implementation
  • The FunctionEvaluator widget shows a message saying that the function cannot be run
  • Connect an implementation
  • The FunctionEvaluator widget is still not runnable

Expected:

  • The state of the FunctionEvaluator updates whenever implementations are connected or disconnected

Examples

Case 1: from not-runnable to runnable

  1. No implementations are connected, evaluator is not-runnable:
    Screenshot from 2024-06-14 11-22-43.png (646×650 px, 54 KB)
  2. We connect them, evaluator is not refreshed:
    Screenshot from 2024-06-14 11-22-31.png (640×674 px, 53 KB)

Case 2: from runnable to not-runnable

  1. There are connected implementations, function can be run in the evaluator widget:
    Screenshot from 2024-06-14 11-19-40.png (570×685 px, 45 KB)
  2. We disconnect them, evaluator widget can still be used:
    Screenshot from 2024-06-14 11-19-48.png (568×682 px, 46 KB)

Event Timeline

Jdforrester-WMF renamed this task from Make run function available once an implementation is approved to Make run function available without a page refresh once an implementation is approved.Aug 7 2023, 5:36 PM
gengh renamed this task from Make run function available without a page refresh once an implementation is approved to Update FunctionEvaluator to runnable when implementations are connected.Fri, Jun 14, 9:26 AM
gengh updated the task description. (Show Details)