ZObjectStoreTest::testUpdateZObject suddenly failing (edit not happening when it should)
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Jdforrester-WMF
	Aug 7 2023, 1:58 PM

Description

00:03:06.573 1) MediaWiki\Extension\WikiLambda\Tests\Integration\ZObjectStoreTest::testUpdateZObject
00:03:06.573 Failed asserting that two strings are equal.
00:03:06.575 --- Expected
00:03:06.575 +++ Actual
00:03:06.575 @@ @@
00:03:06.575  '{\n
00:03:06.575      "Z1K1": "Z2",\n
00:03:06.575      "Z2K1": "Z10000",\n
00:03:06.575 -    "Z2K2": "hello",\n
00:03:06.575 +    "Z2K2": "bye",\n
00:03:06.575      "Z2K3": {\n
00:03:06.575          "Z1K1": "Z12",\n
00:03:06.575          "Z12K1": [\n
00:03:06.575 
00:03:06.575 /workspace/src/extensions/WikiLambda/tests/phpunit/integration/ZObjectStoreTest.php:287
00:03:06.575 /workspace/src/tests/phpunit/MediaWikiIntegrationTestCase.php:547
00:03:06.575 phpvfscomposer:///workspace/src/vendor/phpunit/phpunit/phpunit:97

Caused by rMWb232dafd4116: title: Uncache title from internal title cache on id reset. We need to re-fetch the title in the test, I think.

Details

	Subject	Repo	Branch	Lines +/-
	ZObjectStoreTest::testUpdateZObject: Re-fetch the Title to get the new revId	mediawiki/extensions/WikiLambda	master	+3 -0

Customize query in gerrit

Related Objects

Mentioned Here: rMWb232dafd4116: title: Uncache title from internal title cache on id reset

Event Timeline

Jdforrester-WMF triaged this task as Unbreak Now! priority.Aug 7 2023, 1:58 PM

Jdforrester-WMF created this task.

Change 946548 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] ZObjectStoreTest::testUpdateZObject: Re-fetch the Title to get the new revId

https://gerrit.wikimedia.org/r/946548

gerritbot added a project: Patch-For-Review.Aug 7 2023, 2:08 PM

Change 946548 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] ZObjectStoreTest::testUpdateZObject: Re-fetch the Title to get the new revId

https://gerrit.wikimedia.org/r/946548

Jdforrester-WMF lowered the priority of this task from Unbreak Now! to High.Aug 7 2023, 2:20 PM

Jdforrester-WMF moved this task from To triage to To deploy on the Abstract Wikipedia team board.

Maintenance_bot removed a project: Patch-For-Review.Aug 7 2023, 2:30 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 7 2023, 3:00 PM

Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Aug 18 2023, 5:35 AM

DVrandecic closed this task as Resolved.Sep 27 2023, 11:57 PM

ZObjectStoreTest::testUpdateZObject suddenly failing (edit not happening when it should)Closed, ResolvedPublicActions

Description

Details

Related Objects

Event Timeline

ZObjectStoreTest::testUpdateZObject suddenly failing (edit not happening when it should)
Closed, ResolvedPublic
Actions