Page MenuHomePhabricator
Create Task
Maniphest T343739

Ensure consistent test coverage across Client Hints code
Closed, ResolvedPublic
Actions

Description

https://doc.wikimedia.org/cover-extensions/CheckUser/ reports some code related to Client Hints that is not covered by tests. Ideally this code should be fully covered to avoid issues with deployment.

Details

SubjectRepoBranchLines +/-
Test code that is marked as uncovered related to Client Hintsmediawiki/extensions/CheckUsermaster+213 -20
Customize query in gerrit

Event Timeline

Dreamy_Jazz created this task.Aug 7 2023, 4:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2023, 4:24 PM
Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 7 2023, 4:24 PM
Dreamy_Jazz added a project: http-client-hints.
gerritbot added a comment.Aug 7 2023, 8:36 PM

Change 946622 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Test code that is marked as uncovered related to Client Hints

https://gerrit.wikimedia.org/r/946622

gerritbot added a project: Patch-For-Review.Aug 7 2023, 8:36 PM
Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 7 2023, 9:05 PM
Tchanders assigned this task to Dreamy_Jazz.Aug 8 2023, 1:40 PM
gerritbot added a comment.Aug 10 2023, 12:00 AM

Change 946622 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Test code that is marked as uncovered related to Client Hints

https://gerrit.wikimedia.org/r/946622

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 12:10 AM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 10 2023, 1:00 AM
Dreamy_Jazz moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 10 2023, 10:47 AM

I would suggest that no QA/Testing is needed because this change only modified test files.

Tchanders moved this task from QA/Testing 🐞 to Done Q1 2023-2024 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Aug 16 2023, 4:10 PM
kostajh closed this task as Resolved.Sep 26 2023, 12:13 PM
kostajh edited projects, added http-client-hints (Release 0 (Pilot wikis)); removed http-client-hints.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL