Page MenuHomePhabricator
Create Task
Maniphest T343771

Hard-deprecate manual construction of Language objects (and enforce @internal in MediaWiki 1.44)
Closed, ResolvedPublic
Actions

Description

Calling Language::__construct (or the constructor of a sub class) is deprecated since 1.35 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/450996
The LanguageFactory services has to be used instead.

Replace usage and hard-deprecate the constructor.

It seems it is still called in test code

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbLanguage%5Cw%7B0%2C8%7D%5Cs*%5C%28%5Cs*%5C%29&files=&excludeFiles=&repos=

Details

Related Changes in Gerrit:
Show related patches Customize query in gerrit

Related Objects

Event Timeline

Umherirrender created this task.Aug 7 2023, 11:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2023, 11:26 PM
Umherirrender moved this task from Untriaged to <= 2015 / MW 1.26 on the Technical-Debt (Deprecation process) board.Aug 7 2023, 11:26 PM
Umherirrender moved this task from <= 2015 / MW 1.26 to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.
Umherirrender moved this task from 2018 | MW 1.31 / 1.32 to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.
Lucas_Werkmeister_WMDE subscribed.Aug 8 2023, 4:20 PM
gerritbot added a comment.Aug 8 2023, 4:21 PM

Change 946967 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] tests: Avoid constructing Language directly

https://gerrit.wikimedia.org/r/946967

gerritbot added a project: Patch-For-Review.Aug 8 2023, 4:21 PM
gerritbot added a comment.Aug 12 2023, 12:37 PM

Change 946967 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Avoid constructing Language directly

https://gerrit.wikimedia.org/r/946967

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 12 2023, 1:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 12 2023, 1:10 PM
gerritbot added a comment.Jul 20 2024, 7:37 PM

Change #1055547 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CirrusSearch@master] tests: Use content language instead of instance Language object

https://gerrit.wikimedia.org/r/1055547

gerritbot added a project: Patch-For-Review.Jul 20 2024, 7:37 PM
gerritbot added a comment.Jul 20 2024, 7:40 PM

Change #1055548 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Cite@master] tests: Use LanguageFactory to create qqx language

https://gerrit.wikimedia.org/r/1055548

gerritbot added a comment.Jul 20 2024, 7:41 PM

Change #1055549 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] tests: Use LanguageFactory to create en language

https://gerrit.wikimedia.org/r/1055549

gerritbot added a comment.Jul 20 2024, 7:46 PM

Change #1055550 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use LanguageFactory in ConverterRuleTest

https://gerrit.wikimedia.org/r/1055550

gerritbot added a comment.Jul 20 2024, 7:48 PM

Change #1055551 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use content language in DefaultPreferencesFactoryTest

https://gerrit.wikimedia.org/r/1055551

gerritbot added a comment.Jul 20 2024, 7:56 PM

Change #1055552 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Hard-deprecate manual construction of Language objects

https://gerrit.wikimedia.org/r/1055552

Umherirrender claimed this task.Jul 20 2024, 7:59 PM
gerritbot added a comment.Jul 20 2024, 8:44 PM

Change #1055553 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Use LanguageFactory in FormatMetadataTest

https://gerrit.wikimedia.org/r/1055553

gerritbot added a comment.Jul 20 2024, 8:48 PM

Change #1055549 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Use LanguageFactory to create en language

https://gerrit.wikimedia.org/r/1055549

gerritbot added a comment.Jul 20 2024, 8:53 PM

Change #1055548 merged by jenkins-bot:

[mediawiki/extensions/Cite@master] tests: Use LanguageFactory to create qqx language

https://gerrit.wikimedia.org/r/1055548

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 20 2024, 9:00 PM
gerritbot added a comment.Jul 21 2024, 3:51 AM

Change #1055553 merged by jenkins-bot:

[mediawiki/core@master] tests: Use LanguageFactory in FormatMetadataTest

https://gerrit.wikimedia.org/r/1055553

gerritbot added a comment.Jul 21 2024, 4:03 AM

Change #1055547 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] tests: Use content language instead of instance Language object

https://gerrit.wikimedia.org/r/1055547

gerritbot added a comment.Jul 21 2024, 4:05 AM

Change #1055550 merged by jenkins-bot:

[mediawiki/core@master] tests: Use LanguageFactory in ConverterRuleTest

https://gerrit.wikimedia.org/r/1055550

gerritbot added a comment.Jul 21 2024, 6:24 AM

Change #1055551 merged by jenkins-bot:

[mediawiki/core@master] tests: Use content language in DefaultPreferencesFactoryTest

https://gerrit.wikimedia.org/r/1055551

gerritbot added a comment.Jul 26 2024, 8:25 PM

Change #1055552 merged by jenkins-bot:

[mediawiki/core@master] Hard-deprecate manual construction of Language objects

https://gerrit.wikimedia.org/r/1055552

Maintenance_bot removed a project: Patch-For-Review.Jul 26 2024, 8:31 PM
Umherirrender renamed this task from Hard-deprecate manual construction of Language objects (and enforce @internal a release later) to Hard-deprecate manual construction of Language objects (and enforce @internal in MediaWiki 1.44).Jul 26 2024, 8:34 PM
Umherirrender changed the task status from Open to Stalled.
Umherirrender removed Umherirrender as the assignee of this task.
Umherirrender added a project: MW-1.44-release.
Umherirrender moved this task from Blocker to Deprecate or remove on the MW-1.44-release board.
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 26 2024, 9:00 PM
gerritbot added a comment.Aug 12 2024, 8:49 PM

Change #1062115 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/ProtectionIndicator@master] Use LanguageFactory to create english language object

https://gerrit.wikimedia.org/r/1062115

gerritbot added a project: Patch-For-Review.Aug 12 2024, 8:49 PM
gerritbot added a comment.Aug 12 2024, 8:52 PM

Change #1062116 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoModerator@master] tests: Use mocked language object

https://gerrit.wikimedia.org/r/1062116

gerritbot added a comment.Aug 13 2024, 6:33 PM

Change #1062116 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] tests: Use mocked language object

https://gerrit.wikimedia.org/r/1062116

gerritbot added a comment.Aug 13 2024, 6:33 PM

Change #1062115 merged by jenkins-bot:

[mediawiki/extensions/ProtectionIndicator@master] Use LanguageFactory to create english language object

https://gerrit.wikimedia.org/r/1062115

Umherirrender mentioned this in rEAMOb9d20cb86a1b: tests: Use mocked language object.Aug 13 2024, 6:35 PM
Umherirrender mentioned this in rEPRI8876d1d57057: Use LanguageFactory to create english language object.
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.19; 2024-08-20); removed MW-1.43-notes (1.43.0-wmf.16; 2024-07-30).Aug 13 2024, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 13 2024, 7:30 PM
Umherirrender changed the task status from Stalled to Open.Oct 22 2024, 5:55 PM
Umherirrender claimed this task.Mar 26 2025, 8:52 PM
gerritbot added a comment.Mar 26 2025, 8:52 PM

Change #1131443 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] language: No longer support manual construction of Language objects

https://gerrit.wikimedia.org/r/1131443

gerritbot added a project: Patch-For-Review.Mar 26 2025, 8:52 PM
gerritbot added a comment.Mar 28 2025, 7:13 PM

Change #1131443 merged by jenkins-bot:

[mediawiki/core@master] language: No longer support manual construction of Language objects

https://gerrit.wikimedia.org/r/1131443

Maintenance_bot removed a project: Patch-For-Review.Mar 28 2025, 7:31 PM
ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.23; 2025-04-01).Mar 28 2025, 8:00 PM
Umherirrender closed this task as Resolved.Mar 28 2025, 8:54 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits