Maniphest T343771

Hard-deprecate manual construction of Language objects (and enforce @internal a release later)
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Umherirrender
	Aug 7 2023, 11:26 PM

Tags

Referenced Files

None

Subscribers

Lucas_Werkmeister_WMDE

Description

Calling Language::__construct (or the constructor of a sub class) is deprecated since 1.35 https://gerrit.wikimedia.org/r/c/mediawiki/core/+/450996
The LanguageFactory services has to be used instead.

Replace usage and hard-deprecate the constructor.

It seems it is still called in test code

CodeSearch: https://codesearch.wmcloud.org/search/?q=%5CbLanguage%5Cw%7B0%2C8%7D%5Cs*%5C%28%5Cs*%5C%29&files=&excludeFiles=&repos=

Details

	Subject	Repo	Branch	Lines +/-
	tests: Avoid constructing Language directly	mediawiki/extensions/Wikibase	master	+11 -8

Customize query in gerrit

Event Timeline

Umherirrender created this task.Aug 7 2023, 11:26 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 7 2023, 11:26 PM

Umherirrender moved this task from Untriaged to <= 2015 / MW 1.26 on the Technical-Debt (Deprecation process) board.Aug 7 2023, 11:26 PM

Umherirrender moved this task from <= 2015 / MW 1.26 to 2018 | MW 1.31 / 1.32 on the Technical-Debt (Deprecation process) board.

Umherirrender moved this task from 2018 | MW 1.31 / 1.32 to 2020 | MW 1.35 on the Technical-Debt (Deprecation process) board.

Lucas_Werkmeister_WMDE subscribed.Aug 8 2023, 4:20 PM

Change 946967 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/Wikibase@master] tests: Avoid constructing Language directly

https://gerrit.wikimedia.org/r/946967

gerritbot added a project: Patch-For-Review.Aug 8 2023, 4:21 PM

Change 946967 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Avoid constructing Language directly

https://gerrit.wikimedia.org/r/946967

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 12 2023, 1:00 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 12 2023, 1:10 PM