Page MenuHomePhabricator

TwoColConflict does not scroll preview into view on new vector skin
Closed, ResolvedPublic

Description

It seems that the edit conflict interface does not scroll the preview into view then the button is clicked. It should be generated and added correctly but it's not scrolled into view so it seems for the user, that has nothing happened.

Reported on wiki: https://www.mediawiki.org/wiki/Topic:Xnc3clvelba5bt39

Steps to reproduce:

  • Trigger an edit conflict on a page with the new vector skin ( JS enabled )
  • Click on the Show preview button
  • The preview will be generated and added to the DOM above the conflict solving interface
  • When the preview is generated and added, there view should scroll smoothly to the op to show it.

Event Timeline

Change 947323 had a related patch set uploaded (by WMDE-Fisch; author: WMDE-Fisch):

[mediawiki/extensions/TwoColConflict@master] Use #content to scroll up on preview

https://gerrit.wikimedia.org/r/947323

Change 947323 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Use #content to scroll up on preview

https://gerrit.wikimedia.org/r/947323

Tobi_WMDE_SW claimed this task.