Renaming global account to non-canonical form causes rename jobs to be lost
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Urbanecm_WMF
	Aug 10 2023, 9:28 AM

Description

Steps to reproduce

Go to Special:GlobalRenameUser as a sufficiently privileged user
Put non-canonical username form into the "rename to username" (for example, I renamed Martin Urbanec (test 9) to martin Urbanec_(test 9-renamed)

Expected behaviour

MediaWiki normalizes both usernames and rename completes without any issues.

Observed behaviour

Rename is stuck in the rename queue, and needs to be unstuck via https://wikitech.wikimedia.org/wiki/Stuck_global_renames.

Notes

Example rename form as submitted by me while testing:

Screenshot 2023-08-10 at 11.21.46.png (458×1 px, 73 KB)

Running unstucking script with non-canonical usernames appears to work.

Probable cause: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/CentralAuth/+/934384.

Details

	Subject	Repo	Branch	Lines +/-
	GlobalRename: Ensure status database rows use the normalized name	mediawiki/extensions/CentralAuth	wmf/1.41.0-wmf.20	+1 -1
	GlobalRename: Ensure status database rows use the normalized name	mediawiki/extensions/CentralAuth	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: T343958: Renaming one account multiple times creates duplicate global accounts
T306757: Global renames are slow

Event Timeline

Urbanecm_WMF created this task.Aug 10 2023, 9:28 AM

Restricted Application added a project: MediaWiki-Platform-Team. · View Herald TranscriptAug 10 2023, 9:28 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

taavi mentioned this in T306757: Global renames are slow.Aug 10 2023, 9:30 AM

Urbanecm_WMF mentioned this in T343958: Renaming one account multiple times creates duplicate global accounts.Aug 10 2023, 9:33 AM

taavi claimed this task.Aug 10 2023, 9:38 AM

Change 947794 had a related patch set uploaded (by Majavah; author: Majavah):

[mediawiki/extensions/CentralAuth@master] GlobalRename: Ensure status database rows use the normalized name

https://gerrit.wikimedia.org/r/947794

gerritbot added a project: Patch-For-Review.Aug 10 2023, 9:41 AM

Urbanecm_WMF renamed this task from Renaming global account to non-canonical form causes rename jobs to be post to Renaming global account to non-canonical form causes rename jobs to be lost.Aug 10 2023, 9:41 AM

Change 947794 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] GlobalRename: Ensure status database rows use the normalized name

https://gerrit.wikimedia.org/r/947794

Change 947454 had a related patch set uploaded (by Urbanecm; author: Majavah):

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.20] GlobalRename: Ensure status database rows use the normalized name

https://gerrit.wikimedia.org/r/947454

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 10 2023, 10:00 AM

taavi moved this task from Backlog to GlobalRename on the MediaWiki-extensions-CentralAuth board.Aug 10 2023, 10:35 AM

Change 947454 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@wmf/1.41.0-wmf.20] GlobalRename: Ensure status database rows use the normalized name

https://gerrit.wikimedia.org/r/947454

Maintenance_bot removed a project: Patch-For-Review.Aug 10 2023, 11:30 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-10T11:35:16Z] <taavi@deploy1002> Started scap: Backport for [[gerrit:947454|GlobalRename: Ensure status database rows use the normalized name (T343956)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-10T11:36:48Z] <taavi@deploy1002> taavi and urbanecm: Backport for [[gerrit:947454|GlobalRename: Ensure status database rows use the normalized name (T343956)]] synced to the testservers mwdebug2002.codfw.wmnet, mwdebug1001.eqiad.wmnet, mwdebug1002.eqiad.wmnet, mwdebug2001.codfw.wmnet, and mw-debug kubernetes deployment (accessible via k8s-experimental XWD option)

taavi closed this task as Resolved.Aug 10 2023, 11:41 AM

Mentioned in SAL (#wikimedia-operations) [2023-08-10T11:45:33Z] <taavi@deploy1002> Finished scap: Backport for [[gerrit:947454|GlobalRename: Ensure status database rows use the normalized name (T343956)]] (duration: 10m 17s)

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.20; 2023-08-01); removed MW-1.41-notes (1.41.0-wmf.22; 2023-08-15).Aug 10 2023, 1:00 PM

	F37388784: Screenshot 2023-08-10 at 11.21.46.png
	Aug 10 2023, 9:28 AM

Renaming global account to non-canonical form causes rename jobs to be lostClosed, ResolvedPublicActions