Page MenuHomePhabricator

Add a comment to wgMobileUrlTemplate stating that downstream users should be notified of updates
Closed, ResolvedPublic

Description

The canonical rules for deriving mobile domain names are stored in the MediaWiki config's wgMobileUrlTemplate variable.

Those rules are now mirrored in (1) the Varnish code and (2) our generation script for the wikis canonical data.

The rules will probably change only a few times a decade, so it seems like way too much work to automatically extract the rules. Instead, we should just add a comment to the code stating that the appropriate teams should be notified of changes.

Event Timeline

Change 952925 had a related patch set uploaded (by Neil Shah-Quinn (WMF); author: Neil Shah-Quinn (WMF)):

[operations/mediawiki-config@master] Add comment about mirroring of wgMobileUrlTemplate

https://gerrit.wikimedia.org/r/952925

Now we just need this patch to be deployed during a backport window. I attended a window earlier today, but was asked to get an endorsement from the Traffic team first. That's now done, and I've signed up to attend another window on Thursday.

Change 952925 merged by jenkins-bot:

[operations/mediawiki-config@master] Add comment about mirroring of wgMobileUrlTemplate

https://gerrit.wikimedia.org/r/952925

Mentioned in SAL (#wikimedia-operations) [2023-08-30T20:37:07Z] <hmonroy@deploy1002> Started scap: Backport for [[gerrit:952925|Add comment about mirroring of wgMobileUrlTemplate (T344185)]]

Mentioned in SAL (#wikimedia-operations) [2023-08-30T20:44:18Z] <hmonroy@deploy1002> Finished scap: Backport for [[gerrit:952925|Add comment about mirroring of wgMobileUrlTemplate (T344185)]] (duration: 07m 11s)

nshahquinn-wmf added a subscriber: HMonroy.

@HMonroy thank you for deploying this! I thought I had signed up for the window tomorrow, so I wasn't on IRC today, but I guess it didn't matter 😅