Page MenuHomePhabricator
Create Task
Maniphest T344407

Handle RuntimeExceptions from TranslatorSandboxActionApi on user creation
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

In TranslatorSandboxActionApi, when user creation fails due to IP blocks the API throws a RuntimeException. The API logs this error which may contain private information. This log is readable on IRC and Slack

Skip logging this exception into the error log.

Details

SubjectRepoBranchLines +/-
TranslatorSandboxActionApi: Handle exceptions on user additionmediawiki/extensions/Translatemaster+25 -2
Skip logging RuntimeException on IRC / Slacktranslatewikimaster+10 -0
Customize query in gerrit

Event Timeline

abi_ triaged this task as High priority.Aug 17 2023, 7:20 AM
abi_ created this task.
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 17 2023, 7:20 AM
gerritbot added a comment.Aug 17 2023, 7:26 AM

Change 949630 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[translatewiki@master] Skip logging RuntimeException on IRC / Slack

https://gerrit.wikimedia.org/r/949630

gerritbot added a project: Patch-For-Review.Aug 17 2023, 7:26 AM
abi_ renamed this task from Avoid logging RuntimeExceptions from translatewiki.net on IRC / Slack to Handle RuntimeExceptions from TranslatorSandboxActionApi on user creation.Aug 17 2023, 7:45 AM
abi_ updated the task description. (Show Details)
gerritbot added a comment.Aug 17 2023, 9:04 AM

Change 949840 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Handle uncaught exceptions

https://gerrit.wikimedia.org/r/949840

gerritbot added a comment.Aug 17 2023, 9:10 AM

Change 949630 abandoned by Abijeet Patro:

[translatewiki@master] Skip logging RuntimeException on IRC / Slack

Reason:

Not intended

https://gerrit.wikimedia.org/r/949630

abi_ edited projects, added Language-Team (Language-2023-July-September), affects-translatewiki.net, MediaWiki-extensions-Translate; removed translatewiki.net.Aug 17 2023, 9:18 AM
abi_ moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-July-September) board.
abi_ moved this task from Backlog to Stash/Sandbox on the MediaWiki-extensions-Translate board.
abi_ updated the task description. (Show Details)Aug 21 2023, 10:40 AM
gerritbot added a comment.Aug 21 2023, 1:53 PM

Change 949840 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] TranslatorSandboxActionApi: Handle exceptions on user addition

https://gerrit.wikimedia.org/r/949840

Nikerabbit moved this task from In Review to Check after deployment on the Language-Team (Language-2023-July-September) board.Aug 22 2023, 12:16 PM
ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 29 2023, 11:01 PM
abi_ closed this task as Resolved.Aug 30 2023, 3:06 PM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-July-September) board.

This change is a bit difficult to specifically QA on translatewiki.net. We've not had this error pop out in our logs since this change was deployed. Marking this as done for now.

Nikerabbit added a project: Localization Infrastructure FY2023-24.Sep 6 2023, 7:23 AM
Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Sep 6 2023, 7:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits