Page MenuHomePhabricator

Integrate toolbar search into the toolbar
Open, Needs TriagePublic

Description

T338254 made it possible to search for the specific feature they're looking for within VE.

This task is a follow-up to refine how this search functionality is implemented.

Context

! In T338254#8919119, @ppelberg wrote
...although, I find the current experience to feel off. "Off" in so far as, it's unexpected to me, and I assume for others, that clicking the Toolbar search option from within the ? menu will result in the search experience being opened elsewhere (it looks like the search opens wherever the cursor is placed).

I don't think it's that strange that you are returned to your cursor offset, for example if you click the citation button in the toolbar, you are returned to your cursor offset.

That said, the other tools I cited in the description bring the search widget into the toolbar. While that is an approach we could go down it would require a significant amount of work as it would be introducing UI infrastructure we don't have yet (inputs in toolbars). This task was just meant as a quick way to expose this new functionality.