Maniphest T344794

🍫️ Final cleanup and improvements
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Silvan_WMDE
	Aug 23 2023, 7:59 AM

Tags

Referenced Files

None

Subscribers

Muhammad_Yasser_Jazirahly_WMDE

Ollie.Shotton_WMDE

Description

List of possible things to tidy up:

Remove RequestedSubjectIdValidator

Details

	Subject	Repo	Branch	Lines +/-
	REST: Remove unused `EntityIdValidator` interface	mediawiki/extensions/Wikibase	master	+2 -14
	REST: Remove RequestedSubjectIdValidator and implementations	mediawiki/extensions/Wikibase	master	+0 -154

Customize query in gerrit

Related Objects
Search...

		Status	Subtype	Assigned	Task
		Resolved		Ifrahkhanyaree_WMDE	T343442 🍫️ Create subject specific statement use case wrappers
		Resolved		Jakob_WMDE	T344794 🍫️ Final cleanup and improvements

Event Timeline

Silvan_WMDE created this task.Aug 23 2023, 7:59 AM

Ollie.Shotton_WMDE renamed this task from 🍫️ Remove unneeded code to 🍫️ Final cleanup and improvements.Aug 24 2023, 8:41 AM

Ollie.Shotton_WMDE updated the task description. (Show Details)

Jakob_WMDE claimed this task.Aug 25 2023, 1:16 PM

Jakob_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 2 ) board.

Change 952405 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Remove RequestedSubjectIdValidator and implementations

https://gerrit.wikimedia.org/r/952405

gerritbot added a project: Patch-For-Review.Aug 25 2023, 1:33 PM

Ollie.Shotton_WMDE updated the task description. (Show Details)Aug 25 2023, 2:21 PM

Jakob_WMDE updated the task description. (Show Details)Aug 25 2023, 2:34 PM

Jakob_WMDE moved this task from Doing to Done on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 25 2023, 2:37 PM

Change 952405 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove RequestedSubjectIdValidator and implementations

https://gerrit.wikimedia.org/r/952405

Maintenance_bot removed a project: Patch-For-Review.Aug 25 2023, 3:10 PM

Change 952477 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove unused `EntityIdValidator` interface

https://gerrit.wikimedia.org/r/952477

gerritbot added a project: Patch-For-Review.Aug 25 2023, 4:53 PM

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.25; 2023-09-05).Aug 30 2023, 3:01 AM

Ollie.Shotton_WMDE moved this task from Done to Peer Review on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 30 2023, 12:15 PM

Change 952477 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove unused `EntityIdValidator` interface

https://gerrit.wikimedia.org/r/952477

Jakob_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 2 ) board.Aug 30 2023, 1:05 PM

Maintenance_bot removed a project: Patch-For-Review.Aug 30 2023, 1:10 PM

Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 11 2023, 10:33 AM