Stop deletion of rows in the cu_useragent_clienthints table
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Dreamy_Jazz
	Sep 4 2023, 9:19 PM

Description

After a discussion with T&S and Legal, the decision has been made to stop deletion of rows in the cu_useragent_clienthints table. This is because the rows with no mapping data cannot be linked to a given user or edit. At a later date a maintenance script may be added to purge orphaned rows, but some thought will need to be given to how best to delete these rows without causing race conditions on the delete operation against other insert operations.

Acceptance criteria

Rows are no longer purged from cu_useragent_clienthints

QA Results - Local

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T345591#9155548

Details

Subject	Repo	Branch	Lines +/-
Revert "CheckUser: Set 'debug' log level"	operations/mediawiki-config	master	+0 -1
CheckUser: Set 'debug' log level	operations/mediawiki-config	master	+1 -0
clienthints: Don't delete rows from cu_useragent_clienthints	mediawiki/extensions/CheckUser	master	+62 -146

Customize query in gerrit

Related Objects

Mentioned Here: rECHU7402d9975fb3: Merge "ipReveal.js: Don't pass limit param to revisions and logs APIs"
rMW2f2802eb7526: Merge "rdbms: Small clean ups to query builders"

Event Timeline

Dreamy_Jazz created this task.Sep 4 2023, 9:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 4 2023, 9:19 PM

Dreamy_Jazz claimed this task.Sep 4 2023, 9:24 PM

Dreamy_Jazz updated the task description. (Show Details)

Dreamy_Jazz moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.

Change 954758 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] clienthints: Don't delete rows from cu_useragent_clienthints

https://gerrit.wikimedia.org/r/954758

gerritbot added a project: Patch-For-Review.Sep 4 2023, 11:16 PM

Dreamy_Jazz moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 4 2023, 11:18 PM

Dreamy_Jazz updated the task description. (Show Details)

Change 954758 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] clienthints: Don't delete rows from cu_useragent_clienthints

https://gerrit.wikimedia.org/r/954758

kostajh moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (AHaT Sprint 32 - Baseball Cap) board.Sep 11 2023, 9:14 AM

Maintenance_bot removed a project: Patch-For-Review.Sep 11 2023, 9:30 AM

Suggested QA steps:

Install CheckUser
Set wgCUDMaxAge to 10
Open Google Chrome or Edge
Make an edit to a page
Check that rows exist in the cu_useragent_clienthints_map table
Run SELECT * FROM cu_useragent_clienthints and save the output somewhere for later inspection
Run the purgeOldData.php maintenance script (php maintenance/run.php CheckUser:purgeOldData.php)
Check that no rows exist in the cu_useragent_clienthints_map table
Run SELECT * FROM cu_useragent_clienthints and check that no changes can be seen to the output in step 6.

These steps aim to test that when data expires from the CheckUser tables, only the map rows are deleted. Previously data in cu_useragent_clienthints that became orphaned would be deleted.

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 11 2023, 10:00 AM

@Dreamy_Jazz Rows existed on cu_useragent_clienthints_map. After the purge maintenance script, rows no longer exist on cu_useragent_clienthints_map as seen in the screenshots. Output from `cu_useragent_clienthints ' had no changes before and after purge maintenance script. I will move this to Done. Thanks for all your work!

Status: ✅ PASS
Environment: Local: 1.41.0-alpha (2f2802e) 20:03, 11 September 2023. CheckUser: 2.5 (7402d99) 13:46, 11 September 2023
OS: macOS Ventura
Browser: Chrome 116
Device: MBP
Emulated Device:: N/A
Test Links:
http://localhost:8080/w/index.php?title=Philadelphia_Eagles&action=history

✅AC1: https://phabricator.wikimedia.org/T345591#9155548

Before Purge	After Purge

kostajh moved this task from Backlog to Release 0 (Pilot wikis) on the http-client-hints board.Sep 26 2023, 11:10 AM

kostajh edited projects, added http-client-hints (Release 0 (Pilot wikis)); removed http-client-hints.

kostajh closed this task as Resolved.Sep 26 2023, 7:10 PM

Change 971953 had a related patch set uploaded (by Kosta Harlan; author: Kosta Harlan):

[operations/mediawiki-config@master] CheckUser: Set 'debug' log level

https://gerrit.wikimedia.org/r/971953

gerritbot added a project: Patch-For-Review.Nov 6 2023, 1:34 PM

Change 971953 merged by jenkins-bot:

[operations/mediawiki-config@master] CheckUser: Set 'debug' log level

https://gerrit.wikimedia.org/r/971953

Mentioned in SAL (#wikimedia-operations) [2023-11-06T14:08:12Z] <urbanecm@deploy2002> Started scap: Backport for [[gerrit:971953|CheckUser: Set 'debug' log level (T345591)]]

Maintenance_bot removed a project: Patch-For-Review.Nov 6 2023, 2:10 PM

Mentioned in SAL (#wikimedia-operations) [2023-11-06T14:22:33Z] <urbanecm@deploy2002> Finished scap: Backport for [[gerrit:971953|CheckUser: Set 'debug' log level (T345591)]] (duration: 14m 20s)

Change 972722 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[operations/mediawiki-config@master] Revert "CheckUser: Set 'debug' log level"

https://gerrit.wikimedia.org/r/972722

gerritbot added a project: Patch-For-Review.Nov 9 2023, 12:03 PM

Change 972722 merged by jenkins-bot:

[operations/mediawiki-config@master] Revert "CheckUser: Set 'debug' log level"

https://gerrit.wikimedia.org/r/972722

Mentioned in SAL (#wikimedia-operations) [2023-11-09T14:34:09Z] <kharlan@deploy2002> Started scap: Backport for [[gerrit:972722|Revert "CheckUser: Set 'debug' log level" (T345591)]]

Mentioned in SAL (#wikimedia-operations) [2023-11-09T14:35:41Z] <kharlan@deploy2002> kharlan and dreamyjazz: Backport for [[gerrit:972722|Revert "CheckUser: Set 'debug' log level" (T345591)]] synced to the testservers (https://wikitech.wikimedia.org/wiki/Mwdebug)

Mentioned in SAL (#wikimedia-operations) [2023-11-09T14:41:53Z] <kharlan@deploy2002> Finished scap: Backport for [[gerrit:972722|Revert "CheckUser: Set 'debug' log level" (T345591)]] (duration: 07m 43s)

Maintenance_bot removed a project: Patch-For-Review.Nov 9 2023, 3:10 PM

Stop deletion of rows in the cu_useragent_clienthints tableClosed, ResolvedPublicActions