As per task, from IRC:
<jayme> godog: could you add a todo somewhere to remove the nodeport from the otel-collector deployment? it's not required anymore and it's not protected by things like networkpolicies
It's probably enough to set .Values.service.type: ClusterIP in helmfile.d/services/opentelemetry-collector/values.yaml
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| opentelemetry-collector: move deployment to ClusterIP | operations/deployment-charts | master | +1 -1 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T340551 distributed tracing epic | |||
| Open | None | T320549 distributed tracing v0 [minimum viable] | |||
| Resolved | Clement_Goubert | T320552 Package OpenTelemetry Collector atop our own base Docker images | |||
| Resolved | RLazarus | T320564 OpenTelemetry Collector running as a DaemonSet on Wikikube | |||
| Resolved | fgiunchedi | T345637 Remove nodeport from otel-collector deployment |
Change 969071 had a related patch set uploaded (by Filippo Giunchedi; author: Filippo Giunchedi):
[operations/deployment-charts@master] opentelemetry-collector: move deployment to ClusterIP
Change 969071 merged by Filippo Giunchedi:
[operations/deployment-charts@master] opentelemetry-collector: move deployment to ClusterIP