Page MenuHomePhabricator
Create Task
Maniphest T345715

🚅️ Add support for new fields to the new ValidatingRequestDeserializer
Closed, ResolvedPublic
Actions

Description

The following fields need to be added, and each of them should then be used in one use case:

Details

SubjectRepoBranchLines +/-
REST: Make ValidatingRequestDeserializer support label edit requestsmediawiki/extensions/Wikibasemaster+359 -398
REST: Make ValidatingRequestDeserializer support description edit requestsmediawiki/extensions/Wikibasemaster+362 -382
REST: Validate request per validators ordermediawiki/extensions/Wikibasemaster+4 -6
REST: Make ValidatingRequestDeserializer support patch requestsmediawiki/extensions/Wikibasemaster+305 -309
REST: Use new validation mechanism in AddItemStatementmediawiki/extensions/Wikibasemaster+317 -337
REST: Add EditMetadataRequestValidatingDeserializermediawiki/extensions/Wikibasemaster+215 -0
REST: Add StatementSerializationRequestValidatingDeserializermediawiki/extensions/Wikibasemaster+152 -0
REST: Make ValidatingRequestDeserializer support item fieldsmediawiki/extensions/Wikibasemaster+185 -113
REST: Reuse property id validator in RequestValidationmediawiki/extensions/Wikibasemaster+123 -173
REST: Determine field name by request type, not validatormediawiki/extensions/Wikibasemaster+44 -54
REST: Combine ValidatingRequestDeserializer error testsmediawiki/extensions/Wikibasemaster+48 -70
REST: Make ValidatingRequestDeserializer support language codesmediawiki/extensions/Wikibasemaster+240 -147
REST: Add property id filter to ValidatingRequestDeserializermediawiki/extensions/Wikibasemaster+251 -133
REST: Make ValidatingRequestDeserializer support property idsmediawiki/extensions/Wikibasemaster+210 -102
REST: Make ValidatingRequestDeserializer support statement idsmediawiki/extensions/Wikibasemaster+260 -119
REST: Use ValidatingRequestDeserializer in GetItemmediawiki/extensions/Wikibasemaster+103 -68
Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Silvan_WMDE created this task.Sep 6 2023, 10:05 AM
Jakob_WMDE mentioned this in T345714: 🚅️ Migrate remaining use cases to use the new validation mechanism.Sep 6 2023, 10:11 AM
Jakob_WMDE updated the task description. (Show Details)
Silvan_WMDE updated the task description. (Show Details)Sep 6 2023, 12:46 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 3) board.Sep 6 2023, 1:13 PM
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)
Muhammad_Yasser_Jazirahly_WMDE subscribed.
gerritbot added a comment.Sep 6 2023, 2:14 PM

Change 955339 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support statement ids

https://gerrit.wikimedia.org/r/955339

gerritbot added a project: Patch-For-Review.Sep 6 2023, 2:14 PM
gerritbot added a comment.Sep 6 2023, 3:34 PM

Change 955354 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use ValidatingRequestDeserializer in GetItem

https://gerrit.wikimedia.org/r/955354

Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Sep 6 2023, 3:51 PM
Jakob_WMDE updated the task description. (Show Details)Sep 7 2023, 8:12 AM
gerritbot added a comment.Sep 7 2023, 10:14 AM

Change 955676 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support language codes

https://gerrit.wikimedia.org/r/955676

gerritbot added a comment.Sep 7 2023, 10:30 AM

Change 955681 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: REST: Make ValidatingRequestDeserializer support property ids

https://gerrit.wikimedia.org/r/955681

Jakob_WMDE updated the task description. (Show Details)Sep 7 2023, 10:40 AM
gerritbot added a comment.Sep 7 2023, 11:06 AM

Change 955686 had a related patch set uploaded (by Silvan Heintze; author: Silvan Heintze):

[mediawiki/extensions/Wikibase@master] REST: Add property id filter to ValidatingRequestDeserializer

https://gerrit.wikimedia.org/r/955686

gerritbot added a comment.Sep 7 2023, 2:26 PM

Change 955749 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Combine ValidatingRequestDeserializer error tests

https://gerrit.wikimedia.org/r/955749

Jakob_WMDE claimed this task.Sep 7 2023, 4:27 PM
gerritbot added a comment.Sep 7 2023, 4:28 PM

Change 955785 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Determine field name by request type, not validator

https://gerrit.wikimedia.org/r/955785

gerritbot added a comment.Sep 7 2023, 5:07 PM

Change 955815 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Reuse property id validator in RequestValidation

https://gerrit.wikimedia.org/r/955815

gerritbot added a comment.Sep 8 2023, 10:50 AM

Change 955903 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support item fields

https://gerrit.wikimedia.org/r/955903

gerritbot added a comment.Sep 8 2023, 10:53 AM

Change 955354 abandoned by Jakob:

[mediawiki/extensions/Wikibase@master] REST: Use ValidatingRequestDeserializer in GetItem

Reason:

This is now done in Ic1a403753ea57e2802494f8744bd57e7ef770fbe. Thanks!

https://gerrit.wikimedia.org/r/955354

gerritbot added a comment.Sep 8 2023, 12:14 PM

Change 955339 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support statement ids

https://gerrit.wikimedia.org/r/955339

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 8 2023, 1:00 PM
Muhammad_Yasser_Jazirahly_WMDE updated the task description. (Show Details)Sep 8 2023, 1:03 PM
gerritbot added a comment.Sep 8 2023, 1:17 PM

Change 955936 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add StatementSerializationRequestValidatingDeserializer

https://gerrit.wikimedia.org/r/955936

gerritbot added a comment.Sep 8 2023, 1:58 PM

Change 955944 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Add EditMetadataRequestValidatingDeserializer

https://gerrit.wikimedia.org/r/955944

gerritbot added a comment.Sep 8 2023, 2:19 PM

Change 955681 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support property ids

https://gerrit.wikimedia.org/r/955681

gerritbot added a comment.Sep 8 2023, 2:48 PM

Change 955686 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add property id filter to ValidatingRequestDeserializer

https://gerrit.wikimedia.org/r/955686

gerritbot added a comment.Sep 8 2023, 2:49 PM

Change 955676 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support language codes

https://gerrit.wikimedia.org/r/955676

gerritbot added a comment.Sep 8 2023, 3:11 PM

Change 955749 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Combine ValidatingRequestDeserializer error tests

https://gerrit.wikimedia.org/r/955749

gerritbot added a comment.Sep 8 2023, 3:15 PM

Change 955960 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use new validation mechanism in AddItemStatement

https://gerrit.wikimedia.org/r/955960

Jakob_WMDE updated the task description. (Show Details)Sep 11 2023, 2:01 PM
gerritbot added a comment.Sep 11 2023, 2:47 PM

Change 955785 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Determine field name by request type, not validator

https://gerrit.wikimedia.org/r/955785

gerritbot added a comment.Sep 11 2023, 3:20 PM

Change 955815 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Reuse property id validator in RequestValidation

https://gerrit.wikimedia.org/r/955815

gerritbot added a comment.Sep 12 2023, 8:13 AM

Change 955903 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support item fields

https://gerrit.wikimedia.org/r/955903

gerritbot added a comment.Sep 12 2023, 8:44 AM

Change 955936 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add StatementSerializationRequestValidatingDeserializer

https://gerrit.wikimedia.org/r/955936

ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.27; 2023-09-19); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 12 2023, 9:00 AM
gerritbot added a comment.Sep 12 2023, 10:04 AM

Change 956805 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support patch requests

https://gerrit.wikimedia.org/r/956805

Jakob_WMDE updated the task description. (Show Details)Sep 12 2023, 10:10 AM
gerritbot added a comment.Sep 12 2023, 1:31 PM

Change 955944 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Add EditMetadataRequestValidatingDeserializer

https://gerrit.wikimedia.org/r/955944

gerritbot added a comment.Sep 12 2023, 2:48 PM

Change 956907 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support label edit requests

https://gerrit.wikimedia.org/r/956907

Jakob_WMDE updated the task description. (Show Details)Sep 12 2023, 2:52 PM
gerritbot added a comment.Sep 13 2023, 10:59 AM

Change 957262 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Validate request per validators order

https://gerrit.wikimedia.org/r/957262

gerritbot added a comment.Sep 13 2023, 11:27 AM

Change 955960 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use new validation mechanism in AddItemStatement

https://gerrit.wikimedia.org/r/955960

Jakob_WMDE updated the task description. (Show Details)Sep 13 2023, 12:21 PM
gerritbot added a comment.Sep 13 2023, 2:29 PM

Change 957304 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support description edit requests

https://gerrit.wikimedia.org/r/957304

gerritbot added a comment.Sep 13 2023, 2:42 PM

Change 956805 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support patch requests

https://gerrit.wikimedia.org/r/956805

Jakob_WMDE moved this task from Doing to Peer Review on the Wikibase Product Platform Team WPP (Sprint 3) board.Sep 14 2023, 8:16 AM
Jakob_WMDE updated the task description. (Show Details)
Jakob_WMDE updated the task description. (Show Details)
gerritbot added a comment.Sep 14 2023, 2:21 PM

Change 956907 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support label edit requests

https://gerrit.wikimedia.org/r/956907

gerritbot added a comment.Sep 14 2023, 3:27 PM

Change 957262 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Validate request per validators order

https://gerrit.wikimedia.org/r/957262

gerritbot added a comment.Sep 15 2023, 8:13 AM

Change 957304 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Make ValidatingRequestDeserializer support description edit requests

https://gerrit.wikimedia.org/r/957304

Maintenance_bot removed a project: Patch-For-Review.Sep 15 2023, 8:30 AM
Silvan_WMDE moved this task from Peer Review to Done on the Wikibase Product Platform Team WPP (Sprint 3) board.Sep 15 2023, 9:02 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 19 2023, 10:30 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL