Page MenuHomePhabricator
Create Task
Maniphest T344994

🚅️ Improve use case validation code
Closed, ResolvedPublic8 Estimated Story Points
Actions

Description

There is lots of unnecessary duplication in our use case validation code. Thoughts and ideas for abstractions in https://gist.github.com/jakobw/5ea7c5945f7202c2bfaf67ba553d8773

ACs:

Details

SubjectRepoBranchLines +/-
REST: Remove field interfaces from DeserializedRequestAdaptermediawiki/extensions/Wikibasemaster+0 -25
REST: Use interfaces for use case validatorsmediawiki/extensions/Wikibasemaster+285 -900
REST: Use ValidatingRequestDeserializer in GetItemDescriptionsmediawiki/extensions/Wikibasemaster+38 -62
REST: Create ValidatingRequestDeserializermediawiki/extensions/Wikibasemaster+381 -63
REST: Improve use case validationmediawiki/extensions/Wikibasemaster+233 -84
Customize query in gerrit

Related Objects
Search...

Event Timeline

Jakob_WMDE created this task.Aug 25 2023, 1:43 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 25 2023, 1:43 PM
Jakob_WMDE updated the task description. (Show Details)Aug 25 2023, 2:35 PM
Jakob_WMDE updated the task description. (Show Details)Sep 1 2023, 9:32 AM
gerritbot added a comment.Sep 1 2023, 10:11 AM

Change 954254 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Improve use case validation

https://gerrit.wikimedia.org/r/954254

gerritbot added a project: Patch-For-Review.Sep 1 2023, 10:11 AM
Ifrahkhanyaree_WMDE moved this task from Tech backlog to Ready for planning on the Wikibase Product Platform Team WPP board.Sep 5 2023, 9:45 AM
Ifrahkhanyaree_WMDE set the point value for this task to 8.
Ifrahkhanyaree_WMDE moved this task from Ready for planning to Sprint 3 on the Wikibase Product Platform Team WPP board.
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 3); removed Wikibase Product Platform Team WPP.
Ifrahkhanyaree_WMDE added a project: Wikibase REST API (WPP).Sep 5 2023, 10:07 AM
gerritbot added a comment.Sep 5 2023, 1:54 PM

Change 954922 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Create ValidatingRequestDeserializer

https://gerrit.wikimedia.org/r/954922

Muhammad_Yasser_Jazirahly_WMDE moved this task from To Do to Doing on the Wikibase Product Platform Team WPP (Sprint 3) board.Sep 5 2023, 4:03 PM
gerritbot added a comment.Sep 5 2023, 4:08 PM

Change 954966 had a related patch set uploaded (by Muhammad Jaziraly; author: Muhammad Jaziraly):

[mediawiki/extensions/Wikibase@master] REST: Use ValidatingRequestDeserializer in GetItemDescriptions

https://gerrit.wikimedia.org/r/954966

Silvan_WMDE renamed this task from Improve use case validation code to 🚅️ Improve use case validation code.Sep 6 2023, 9:42 AM
gerritbot added a comment.Sep 6 2023, 12:44 PM

Change 954254 abandoned by Silvan Heintze:

[mediawiki/extensions/Wikibase@master] REST: Improve use case validation

Reason:

re-started via I4325351a50e9b19dfbe597552f866b2c85214324

https://gerrit.wikimedia.org/r/954254

gerritbot added a comment.Sep 6 2023, 12:57 PM

Change 954922 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Create ValidatingRequestDeserializer

https://gerrit.wikimedia.org/r/954922

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 6 2023, 1:00 PM
Muhammad_Yasser_Jazirahly_WMDE moved this task from Doing to To Do on the Wikibase Product Platform Team WPP (Sprint 3) board.Sep 6 2023, 1:13 PM
gerritbot added a comment.Sep 6 2023, 1:49 PM

Change 954966 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use ValidatingRequestDeserializer in GetItemDescriptions

https://gerrit.wikimedia.org/r/954966

Maintenance_bot removed a project: Patch-For-Review.Sep 6 2023, 2:10 PM
Ifrahkhanyaree_WMDE moved this task from Backlog to Happening now on the Wikibase REST API (WPP) board.Sep 7 2023, 8:49 AM
gerritbot added a comment.Sep 18 2023, 12:52 PM

Change 958437 had a related patch set uploaded (by Jakob; author: Jakob):

[mediawiki/extensions/Wikibase@master] REST: Use interfaces for use case validators

https://gerrit.wikimedia.org/r/958437

gerritbot added a project: Patch-For-Review.Sep 18 2023, 12:52 PM
gerritbot added a comment.Sep 18 2023, 5:12 PM

Change 958437 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Use interfaces for use case validators

https://gerrit.wikimedia.org/r/958437

Maintenance_bot removed a project: Patch-For-Review.Sep 18 2023, 5:30 PM
Ifrahkhanyaree_WMDE edited projects, added Wikibase Product Platform Team WPP (Sprint 4); removed Wikibase Product Platform Team WPP (Sprint 3).Sep 19 2023, 9:25 AM
gerritbot added a comment.Sep 19 2023, 9:25 AM

Change 958891 had a related patch set uploaded (by Ollie Shotton; author: Ollie Shotton):

[mediawiki/extensions/Wikibase@master] REST: Remove field interfaces from DeserializedRequestAdapter

https://gerrit.wikimedia.org/r/958891

gerritbot added a project: Patch-For-Review.Sep 19 2023, 9:25 AM
Ifrahkhanyaree_WMDE closed subtask T345718: 🚅️ Ensure the same request is never validated twice as Resolved.Sep 19 2023, 10:30 AM
Ifrahkhanyaree_WMDE closed subtask T345715: 🚅️ Add support for new fields to the new ValidatingRequestDeserializer as Resolved.
Ifrahkhanyaree_WMDE closed subtask T345714: 🚅️ Migrate remaining use cases to use the new validation mechanism as Resolved.
gerritbot added a comment.Sep 19 2023, 10:49 AM

Change 958891 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] REST: Remove field interfaces from DeserializedRequestAdapter

https://gerrit.wikimedia.org/r/958891

Maintenance_bot removed a project: Patch-For-Review.Sep 19 2023, 11:10 AM
ReleaseTaggerBot edited projects, added MW-1.41-notes (1.41.0-wmf.28; 2023-09-26); removed MW-1.41-notes (1.41.0-wmf.26; 2023-09-12).Sep 19 2023, 1:01 PM
Jakob_WMDE moved this task from To Do to Done on the Wikibase Product Platform Team WPP (Sprint 4) board.Sep 21 2023, 9:06 AM
Ifrahkhanyaree_WMDE closed this task as Resolved.Sep 25 2023, 8:15 AM
Ifrahkhanyaree_WMDE claimed this task.
Ifrahkhanyaree_WMDE moved this task from Happening now to Done on the Wikibase REST API (WPP) board.
Ifrahkhanyaree_WMDE closed subtask T346615: 🚅️ Optimize validator instantiation code as Resolved.
Ifrahkhanyaree_WMDE closed subtask T346613: 🚅️ Move all request validation code to a new namespace as Resolved.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL