Page MenuHomePhabricator

Multi-content diffs content missing when switching from Visual to Wikitext mode with Inline enabled
Closed, ResolvedPublicBUG REPORT

Description

What is the problem?

If I am viewing a diff with content from multiple slots, if I enable Inline mode, switch to Visual and back to Wikitext, some or all of the slots will disappear.

They can be returned by toggling Inline mode.

https://www.mediawiki.org/wiki/Multi-Content_Revisions

Steps to reproduce problem
  1. https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File%3AIcon_for_char_%E8%A6%8F_purple_beige_32x32.png&diff=290346&oldid=114026&diffmode=wikitext&diff-type=inline
  2. Notice that there are two "slots" in the diff content, one for the wiktext in an inline diff format and another with the title "mediainfo" in a two-column diff format
  3. Click "Visual"
  4. Click "Wikitext"

Expected behavior: Content is the same as it was in step 1
Observed behavior: One or both slots in the diff are missing

Environment

Browser: Firefox 102. Chromium 116.
Wiki(s): https://commons.wikimedia.beta.wmflabs.org MediaWiki 1.41.0-alpha (564a33b) 11:42, 7 September 2023. WikibaseMediaInfo 0.1.0 (152ded4) 06:45, 4 September 2023.

Screenshots

output.gif (768×1 px, 706 KB)

QA Results - Beta

Event Timeline

Change 960152 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Fix inline/table format mixed toggling

https://gerrit.wikimedia.org/r/960152

Change 960152 merged by jenkins-bot:

[mediawiki/core@master] Fix inline/table format mixed toggling

https://gerrit.wikimedia.org/r/960152

Change 960154 had a related patch set uploaded (by Bartosz Dziewoński; author: HMonroy):

[mediawiki/extensions/VisualEditor@master] Fix wikitext mixed toggling

https://gerrit.wikimedia.org/r/960154

Change 960154 merged by jenkins-bot:

[mediawiki/extensions/VisualEditor@master] Fix wikitext mixed toggling

https://gerrit.wikimedia.org/r/960154

@HMonroy Contents are the same and are not missing regardless of rights, zoom, or browsers as seen in the gif example below. I'll move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Beta: 1.41.0-alpha (475e5d7) 4, October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 117, Safari 17.0
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://commons.wikimedia.beta.wmflabs.org/w/index.php?title=File%3AIcon_for_char_%E8%A6%8F_purple_beige_32x32.png&diff=290346&oldid=114026&diffmode=wikitext&diff-type=inline

✅AC1: https://phabricator.wikimedia.org/T345836

2023-10-04_14-06-13.mp4.gif (1×3 px, 2 MB)