Page MenuHomePhabricator
Create Task
Maniphest T345848

Conflicting messaging between function evaluator and function details page
Closed, ResolvedPublic
Actions

Description

When a function has no connected implementations we display a message inside the function evaluator, and the message text reads "This function has no approved implementations."

CleanShot 2023-09-07 at 16.15.41@2x.png (2,412×1,406 px, 222 KB)

On the function details page we use the wording "Connect/ed" or "Disconnect/ed" so we should update the message text to be "This function has no connected implementations."

Details

Related Changes in Gerrit:
SubjectAuthorRepoBranchLines +/-
Function Details: we should update the message text to be "This function has no connected implementations."Daphne Smitmediawiki/extensions/WikiLambdamaster+2 -2
Use non-namespaced verison of ConfigException to MW 1.40 supportAbijeet Patromediawiki/extensions/Translatemaster+1 -1
Customize query in gerrit

Event Timeline

AAlhazwani-WMF created this task.Sep 7 2023, 2:18 PM
Jdforrester-WMF triaged this task as Low priority.Sep 28 2023, 4:37 PM
Jdforrester-WMF moved this task from To Triage to Backlog on the Abstract Wikipedia team board.
Jdforrester-WMF added a project: WikiLambda Front-end.
gerritbot added a comment.Apr 25 2024, 4:21 AM

Change #1024083 had a related patch set uploaded (by Abijeet Patro; author: Abijeet Patro):

[mediawiki/extensions/Translate@master] Use non-namespaced verison of ConfigException to MW 1.40 support

https://gerrit.wikimedia.org/r/1024083

gerritbot added a project: Patch-For-Review.Apr 25 2024, 4:21 AM
gerritbot added a comment.Apr 25 2024, 5:18 AM

Change #1024083 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Use non-namespaced verison of ConfigException to MW 1.40 support

https://gerrit.wikimedia.org/r/1024083

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30).Apr 25 2024, 6:00 AM
DSmit-WMF changed the task status from Open to In Progress.Aug 30 2024, 11:35 AM
DSmit-WMF claimed this task.
gerritbot added a comment.Aug 30 2024, 11:36 AM

Change #1069150 had a related patch set uploaded (by Daphne Smit; author: Daphne Smit):

[mediawiki/extensions/WikiLambda@master] Function Details: we should update the message text to be "This function has no connected implementations."

https://gerrit.wikimedia.org/r/1069150

Jdforrester-WMF edited projects, added: Abstract Wikipedia team (25Q1 (Jul–Sep)); removed: MW-1.43-notes (1.43.0-wmf.3; 2024-04-30), Abstract Wikipedia team.Aug 30 2024, 2:40 PM
Jdforrester-WMF moved this task from Incoming to Ready to deploy on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.
gerritbot added a comment.Aug 30 2024, 2:49 PM

Change #1069150 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Function Details: we should update the message text to be "This function has no connected implementations."

https://gerrit.wikimedia.org/r/1069150

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.21; 2024-09-03).Aug 30 2024, 3:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 30 2024, 3:31 PM
Jdforrester-WMF moved this task from Ready to deploy to Needs Sign-off on the Abstract Wikipedia team (25Q1 (Jul–Sep)) board.Sep 6 2024, 1:46 PM
Jdforrester-WMF closed this task as Resolved.Oct 7 2024, 4:29 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits