Page MenuHomePhabricator

Rename the shellbox service to shellbox-score
Open, LowPublic

Description

As of this writing, we have five shellbox services under helmfile.d/services/:

shellbox/
shellbox-constraints/
shellbox-media/
shellbox-syntaxhighlight/
shellbox-timeline/

Each is a different flavour, meaning it sandboxes a different command. shellbox/ isn't special in that regard, its flavour is "score" for shelling out to lilypond -- it's only named without a suffix because it happened to be the first one. For clarity, we should rename it to shellbox-score. Same goes for the k8s namespace.

Not a ton of resources are tied up in this service, so the easiest way is probably to create a duplicate service with the correct name shellbox-score, switch over to it by repointing the mediawiki config, and then delete the original service.

The shellbox/ directory is special in one way: its global.yaml is canonical for all shellbox services, which symlink to it. We can keep that arrangement, with shellbox-score/global.yaml being the target of those links.

Related Objects

Event Timeline

RLazarus created this task.

No problem with the general approach, I propose using a _shellbox_common_ directory like we have a _aqs2-common_ and a _mediawiki-common_ directory in helmfile.d/services and symlink from there.

I propose using a _shellbox_common_ directory like we have a _aqs2-common_ and a _mediawiki-common_ directory in helmfile.d/services and symlink from there.

SGTM!

Picking up the task

Oh rad, thank you -- note that https://gerrit.wikimedia.org/r/955772 is based on using shellbox/ where it is, so you should probably either wait until T329491 is complete or coordinate with @akosiaris about the churn. (I was just planning on waiting, but you're welcome to jump on this faster if you like!)