Page MenuHomePhabricator

PageTriage NewPagesFeed - implement low-effort/low-risk DST-recommended changes
Closed, ResolvedPublic

Description

DST = Design Systems Team (https://www.mediawiki.org/wiki/Design_Systems_Team)
From T343591#9117901

  • filter menu button should follow the toggle button pattern defined in the WAI APG by adding role="button" and :aria-pressed="settings.controlMenuOpen"
  • Add &:hover { cursor: @cursor-base--hover; ) to interactive elements, especially in the filters popup. CdxRadios already have this (pointer cursor when hovering over the input or the label), so unifying that behavior across the inputs would be nice.
  • ListFilterMenu has a couple uses of the deprecated type prop of CdxButton, recommend changing to weight (although I'd also recommend not having two primary buttons)

Event Timeline

Scardenasmolinar changed the task status from Open to In Progress.Oct 6 2023, 7:28 PM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.

Change 964107 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/PageTriage@master] Implement DST recommended changes

https://gerrit.wikimedia.org/r/964107

Change 964107 merged by jenkins-bot:

[mediawiki/extensions/PageTriage@master] Implement DST recommended changes

https://gerrit.wikimedia.org/r/964107