Page MenuHomePhabricator

Review and unreview actions sometimes get out of sync with patrol and unpatrol actions
Open, Needs TriagePublicBUG REPORT

Description

Terminology

There's a patrol log and patrol/unpatrol actions, which use MediaWiki Core's https://www.mediawiki.org/wiki/Help:Patrolled_edits

There's a page curation log and review/unreview actions, which use MediaWiki extension PageTriage https://www.mediawiki.org/wiki/Extension:PageTriage

The bug

Assuming that PageTriage is installed...

In theory, anytime a page is marked as reviewed, it should also mark the page as patrolled. And anytime a page is marked as unreviewed, it should also mark the page as unpatrolled.

However, I have seen plenty of evidence that this does not happen, because "review" actions sometimes do not make it into the "patrol" log.

This ticket is to investigate what actions lead to these two logs getting out of sync, and to fix them.

Things to check

Note: patrolling is only stored in recentchanges, not anywhere else, so only lasts 30-90 days

  • Make sure that marking as reviewed also marks as patrolled
  • Make sure that marking as unreviewed also marks as unpatrolled
  • Make sure that marking as patrolled also marks as reviewed
  • Make sure that marking as unpatrolled also marks as unreviewed (unpatrolling is not possible, T22399: action=markpatrolled cannot be undone)
  • Look up what other actions can cause a review/unreview action, and investigate those
    • Page moves
    • Deletion
    • Undeletion
  • Is there a chance that patrolled edits fundamentally works differently than reviewing? For example, maybe patrolled edits is by diff rather than by article, which could cause challenges with keeping them in sync?

Event Timeline

Another solution to this ticket might be to stop having the patrol API mark pages as reviewed in PageTriage. In other words, force new page reviewers to use the Page Curation toolbar. This would involve some complaints during the initial disabling, but would clean up the logs in the long run, reduce code, and get rid of the unintuitiveness of this patrolled vs reviewed thing.

Perhaps adding some code to hide the [Mark this page as patrolled] link from everyone at all times is the way to go here. Downside is if someone has a workflow of clicking this link in non-mainspace, this would disrupt their workflow.

  • post at WT:NPPR and WP:VPT, ask if this would break anyone's workflows
  • see if folks do something weird with patrolled edits in other namespaces, such as checking every uploaded file in the file namespace and marking it as patrolled
  • wikimedia-site-request to turn off patrolled edits (hopefully getting rid of the patrol API, the [mark this page as patrolled] link, and the red exclamation mark in recent changes, but without messing with the patrol userright) (test and see if this is possible)
    • $wgUseRCPatrol = false; - exclamation marks in recent changes
    • $wgUseNPPatrol = false;
    • $wgUseFilePatrol = false;
  • remove patrol API calls from PageTriage

Might want to start a discussion at WT:NPP to gauge how many people still use the patrol button instead of the curation toolbar. Also, can we disable the button in mainspace only? That would be the best of both worlds in terms of unlinking it from PageTriage while causing as little change as possible.