"(n intermediate revisions by m users not shown)" is not displayed when toggling inline
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Sep 13 2023, 10:04 AM

Description

What is the problem?

When viewing diffs which are not sequential, above the diff content will be displayed something like:

(2 intermediate revisions by 2 users not shown)

When toggling inline mode, this does not appear. It only appears on the type of diff (inline or two-column) that was enabled when you first loaded the page.

Steps to reproduce problem

Case one:

Go to https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=table
See (2 intermediate revisions by 2 users not shown)
Click the Inline toggle (to turn on inline mode)

Expected behavior: You still see (2 intermediate revisions by 2 users not shown)
Observed behavior: It is not there

Case two:

Go to https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=inline
See (2 intermediate revisions by 2 users not shown)
Click the Inline toggle (to turn on two-column mode)

Expected behavior: You still see (2 intermediate revisions by 2 users not shown)
Observed behavior: It is not there

Environment

Browser: Firefox 102. Chromium 116.
Wiki(s): https://www.mediawiki.org MediaWiki 1.41.0-wmf.26 (f511adf) 00:18, 12 September 2023.

Screenshots

Before toggling inline:

intermediate_revisions_before.png (542×1 px, 75 KB)

After toggling inline:

intermediate_revisions_after.png (444×1 px, 63 KB)

QA Results - Beta

AC	Status	Details
1	✅	https://phabricator.wikimedia.org/T346220 - Case 1 here
2	✅	https://phabricator.wikimedia.org/T346220 - Case 2

Details

	Subject	Repo	Branch	Lines +/-
	Fix inline/table format mixed toggling	mediawiki/core	master	+19 -13

Customize query in gerrit

Related Objects

Mentioned Here: rMWfce00a8828ff: Localisation updates from https://translatewiki.net.
rMW475e5d757e9e: Make use of str_contains/str_starts_with in a few places
rMWf511adffb110: Merge "EditPage: Remove various deprecated properties and methods"

Event Timeline

dom_walden created this task.Sep 13 2023, 10:04 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 13 2023, 10:04 AM

dom_walden updated the task description. (Show Details)Sep 13 2023, 10:32 AM

HMonroy edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.Sep 14 2023, 4:39 PM

TheresNoTime claimed this task.Sep 19 2023, 10:03 AM

TheresNoTime moved this task from Ready 🎬 to In Development 💻 on the Community-Tech (CommTech-Kanban) board.

@TheresNoTime looks like https://gerrit.wikimedia.org/r/c/mediawiki/core/+/960152 also fixes this bug. I tested and the (2 intermediate revisions by 2 users not shown) case and it is now being selected as part of the table header so this issue should be resolved (crossing fingers). I think we can move it to under review.

Change 960152 had a related patch set uploaded (by HMonroy; author: HMonroy):

[mediawiki/core@master] Fix inline/table format mixed toggling

https://gerrit.wikimedia.org/r/960152

gerritbot added a project: Patch-For-Review.Oct 2 2023, 9:28 PM

HMonroy moved this task from In Development 💻 to Review/Feedback 💬 on the Community-Tech (CommTech-Kanban) board.Oct 2 2023, 9:28 PM

In T346220#9217758, @HMonroy wrote:

@TheresNoTime looks like https://gerrit.wikimedia.org/r/c/mediawiki/core/+/960152 also fixes this bug. I tested and the (2 intermediate revisions by 2 users not shown) case and it is now being selected as part of the table header so this issue should be resolved (crossing fingers). I think we can move it to under review.

Awesome, thank you :-) reassigned this to you and have reviewed that patch

Change 960152 merged by jenkins-bot:

[mediawiki/core@master] Fix inline/table format mixed toggling

https://gerrit.wikimedia.org/r/960152

ReleaseTaggerBot added a project: MW-1.41-notes (1.41.0-wmf.30; 2023-10-10).Oct 3 2023, 11:00 AM

Maintenance_bot removed a project: Patch-For-Review.Oct 3 2023, 11:10 AM

HMonroy moved this task from Review/Feedback 💬 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Oct 3 2023, 11:30 PM

@HMonroy Did you want (2 intermediate revisions by 2 users not shown) to be shown when it's toggle on and off or just when you toggle the inline on? It fails when only on case 1 below as seen in the gif. It looks like when the diff-type=inline is in the URL, it toggles fine, but when you have diff-type=table, it doesn't have it when you toggle the inline.

Status: ❌ FAIL
Environment: Mediawiki: 1.41.0-wmf.29
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 117, Safari 17.0
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=table
https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=inline

❌AC1: https://phabricator.wikimedia.org/T346220 - Case 1: https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=table

2023-10-05_11-38-04.mp4.gif (1×2 px, 1 MB)

✅AC2: https://phabricator.wikimedia.org/T346220 - Case 2: https://www.mediawiki.org/w/index.php?title=File%3A2page.jpg&diff=4081192&oldid=397109&diff-type=inline

2023-10-05_11-37-06.mp4.gif (1×2 px, 1 MB)

GMikesell-WMF moved this task from QA 🐛 to Needs Attention 👀 on the Community-Tech (CommTech-Kanban) board.Oct 5 2023, 6:49 PM

GMikesell-WMF moved this task from Needs Attention 👀 to QA 🐛 on the Community-Tech (CommTech-Kanban) board.Oct 5 2023, 7:16 PM

@HMonroy I see the patch did not make it to Mediawiki, hence why it's not working. I did test it out in Beta and (2 intermediate revisions by 2 users not shown) is now shown whether the toggle button is on or off as seen in the gifs below. I will move this to Done. Thanks for your work!

Status: ✅PASS
Environment: Beta: 1.41.0-alpha (fce00a8) 5, October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 117, Safari 17.0
Device: MBA M2
Emulated Device:: n/a
Test Links:
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=File%3A2page.jpg&diff=602905&oldid=602902&diff-type=inline
https://en.wikipedia.beta.wmflabs.org/w/index.php?title=File%3A2page.jpg&diff=602905&oldid=602902&diff-type=table

✅AC1: https://phabricator.wikimedia.org/T346220 - Case 1: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=File%3A2page.jpg&diff=602905&oldid=602902&diff-type=table

2023-10-05_12-43-24.mp4.gif (1×2 px, 1 MB)

✅AC2: https://phabricator.wikimedia.org/T346220 - Case 2: https://en.wikipedia.beta.wmflabs.org/w/index.php?title=File%3A2page.jpg&diff=602905&oldid=602902&diff-type=inline

2023-10-05_12-42-25.mp4.gif (1×2 px, 1 MB)

GMikesell-WMF updated the task description. (Show Details)Oct 5 2023, 9:23 PM

GMikesell-WMF moved this task from QA 🐛 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

TheresNoTime closed this task as Resolved.Oct 9 2023, 9:05 AM

	F37717797: intermediate_revisions_after.png
	Sep 13 2023, 10:04 AM

	F37717794: intermediate_revisions_before.png
	Sep 13 2023, 10:04 AM

"(n intermediate revisions by m users not shown)" is not displayed when toggling inlineClosed, ResolvedPublicBUG REPORTActions