Well, the title basicly tells the entire story. The apc.css file should be loaded with ResourceLoader.
Version: unspecified
Severity: minor
lcawte | |
Nov 26 2011, 7:36 PM |
F8484: patch(2).diff | |
Nov 22 2014, 12:01 AM |
Well, the title basicly tells the entire story. The apc.css file should be loaded with ResourceLoader.
Version: unspecified
Severity: minor
Status | Subtype | Assigned | Task | ||
---|---|---|---|---|---|
Resolved | None | T31713 Extensions that need resource loader-ifying (tracking) | |||
Resolved | lcawte | T34662 apc.css should be loaded with ResourceLoader |
Created attachment 9558
Add ResourceLoader support
attachment patch.diff ignored as obsolete
Comment on attachment 9558
Add ResourceLoader support
Index: APC.php
- APC.php (revision 104292)
+++ APC.php (working copy)
@@ -32,3 +32,7 @@
$wgSpecialPageGroups['APC'] = 'wiki';$wgAvailableRights[] = 'apc';
+
+$wgResourceModules['ext.apc'] = array(
+ 'styles' => 'apc.css',
+ 'localBasePath' => dirname(FILE),
+ 'remoteExtPath' => 'APC'
+);Index: SpecialAPC.php
- SpecialAPC.php (revision 104292)
+++ SpecialAPC.php (working copy)
@@ -100,9 +100,7 @@} }
- $wgOut->addLink( array( 'rel' => 'stylesheet', 'type' => 'text/css',
- 'href' => "$wgScriptPath/extensions/APC/apc.css?$wgStyleVersion", )
- );
+ $wgOut->addModuleStyles( 'ext.apc' );
$this->getLogo(); $this->mainMenu();
john wrote:
Comment on attachment 9559
?debug=1 works
+ 'styles' => 'apc.css',
Spaces, otherwise I'll apply it.
Created attachment 9560
Adds ResourceLoader support for apc.css (fix previous patch errors)
Fix spacing.
Attached: