Page MenuHomePhabricator

Review Revert Risk reports from WME
Open, Needs TriagePublic

Description

The WME team is testing revert risk agnostic on Lift Wing, and they reported a high number of HTTP 400s related to two use cases:


  • Example payload:
{
    "rev_id": 133170407,
    "lang": "ru"
}
  • Response from Lift Wing:
{"detail": "The necessary features cannot be obtained from the MediaWiki API. It can be the revision, parent revision, page information, or user information. This could be because the data does not exist or has been deleted."}
  • More info: doc

  • Example payload:
{
    "rev_id": 319465,
    "lang": "ha"
}
  • Response from Lift Wing:
{
    "error": "Unsupported lang: ha."
}
  • More info: doc

Event Timeline

elukey updated the task description. (Show Details)

For the first use case, I tried to check logs in Lift Wing for ruwiki:133170407, and I see this:

2023-09-22 07:34:41.247 71 root ERROR [preprocess():97] get_current_revision returned empty results for revision 133170407 (ru)

The get_current_revision function seems to come from Knowledge Integrity, so it shouldn't be a model-server/isvc code issue afaics.

I quickly checked the two problematic revisions (ruwiki:133170407 and nlwiki:66027941) reported in the doc. Both of them are new pages, meaning they are the first revision of the page. This can cause errors because revert risk model requires the parent revision to calculate the difference between revisions, but in this case, there is no parent revision available.

In the kserve logs, we will also see logs like the following:

root ERROR [get_parent_revision():259] Failed to fetch info for parent: 0. Reason: KeyError('pages')

Errors occur in the get_parent_revision() function from Knowledge Integrity and the parent revision id is shown as 0.

Thanks for looking into this. So, in summary:

  1. We can only call revertrisk-language-agnostic API when parent revision exists.
  2. Language support issue will be fixed. We can continue to call revertrisk-language-agnostic for all languages wiki projects in ns 0 for non-first revisions.

Hi @prabhat, the language support issue should be resolved in T347330. We have deployed the new Revert Risk language agnostic model to production.

@achou Thanks for the heads up. Will verify on our end.

In the last 50 hours, we haven't seen any "Unsupported lang" issue.
Thanks for fixing this.

In the last 50 hours, we haven't seen any "Unsupported lang" issue.
Thanks for fixing this.

Great! Thanks to all the ML team, specially to @achou and big thanks to @MunizaA for detecting and fixing the issue!

Hi folks. I don't see any further requests on this task. I'm going to remove it from Research's backlog. If this is incorrect add us back or assign a subtask to us.