Trailing whitespace in message reportincident-dialog-harassment-lead-in-to-harassment-examples
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Nikerabbit
	Sep 27 2023, 7:31 AM

Description

rEREI94596e80e21d: Add first dialog page with explainer text and resource links introduced a message with a trailing whitespace which is not supported in messages. Please remove it, and if it is necessary for functionality, add the space in code instead.

Details

	Subject	Repo	Branch	Lines +/-
	Remove trailing space from step 1 dialog message	mediawiki/extensions/ReportIncident	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned In: rEREI30acf4425b77: Remove trailing space from step 1 dialog message
Mentioned Here: rEREI94596e80e21d: Add first dialog page with explainer text and resource links

Event Timeline

Nikerabbit created this task.Sep 27 2023, 7:31 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptSep 27 2023, 7:31 AM

Aklapper renamed this task from Trailing whitespace in message to Trailing whitespace in message reportincident-dialog-harassment-lead-in-to-harassment-examples.Sep 27 2023, 9:12 AM

Thanks for raising this.

Change 961374 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/ReportIncident@master] Remove trailing space from step 1 dialog message

https://gerrit.wikimedia.org/r/961374

gerritbot added a project: Patch-For-Review.Sep 27 2023, 12:27 PM

Dreamy_Jazz moved this task from 🎬 Ready to 🔍 Review/Feedback on the Trust and Safety Tools Team Backlog (Kanban) board.Sep 27 2023, 12:28 PM

Change 961374 merged by jenkins-bot:

[mediawiki/extensions/ReportIncident@master] Remove trailing space from step 1 dialog message

https://gerrit.wikimedia.org/r/961374

Dreamy_Jazz mentioned this in rEREI30acf4425b77: Remove trailing space from step 1 dialog message.Sep 27 2023, 12:35 PM

Suggested QA steps:

Use a wiki without this fix applied
Open the report dialog and leave it on step 1
Open a page with this change applied
Open the report dialog and leave it on step 1
Verification step 1: Check that there is no visual difference between the two dialogs on step 1

The aim of this test is to check that no visual changes were made due to this change as the whitespace that was removed was not visible (as it was trailing).

Maintenance_bot removed a project: Patch-For-Review.Sep 27 2023, 1:10 PM

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/6a32cd58e1/w

Test wiki created on Patch demo by DJacksonA using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/fdeb74d8d9/w

Test wiki on Patch demo by DJacksonA using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/fdeb74d8d9/w/~~

I have verified the information listed in the ticket Description has been implemented.

Djackson-ctr moved this task from 🐛 QA to 🤘 Done on the Trust and Safety Tools Team Backlog (Kanban) board.Oct 6 2023, 7:37 PM

kostajh closed this task as Resolved.Oct 9 2023, 8:24 AM