Page MenuHomePhabricator

Log action text shown when reading new does not respect the deleted status of the log
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce
  1. Install the CheckUser extension
  2. Add $wgCheckUserEventTablesMigrationStage = SCHEMA_COMPAT_WRITE_OLD | SCHEMA_COMPAT_NEW; to your LocalSettings.php file.
  3. Log into an account with the suppressor group
  4. Create a page
  5. Delete said page with the suppression option checked
  6. Log into a different account with the checkuser group (and importantly not the suppressor group)
  7. Load Special:CheckUser
  8. Run a 'Get edits' check on the username of the account used in steps 3 to 5.

Expected behaviour: The log entry action text for the suppression is hidden
Observed behaviour: The log entry action text is shown.

Extra information

Raised as an issue in QA of T328995.

When wgCheckUserEventTablesMigrationStage is set to include SCHEMA_COMPAT_READ_NEW, the generated action text for log events taken from the cu_log_event table does not respect the deleted status of the log entry.

This was already the case when SCHEMA_COMPAT_READ_OLD was instead set, but this is slightly worse as any log entry deleted on creation (such as a page suppression log event) is now shown.

QA Results - Local

Event Timeline

Change 962088 had a related patch set uploaded (by Dreamy Jazz; author: Dreamy Jazz):

[mediawiki/extensions/CheckUser@master] Respect log_deleted when reading new in Special:CheckUser 'Get edits'

https://gerrit.wikimedia.org/r/962088

Change 962088 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] Respect log_deleted when reading new in Special:CheckUser 'Get edits'

https://gerrit.wikimedia.org/r/962088

@Dreamy_Jazz The log entry action text for the suppression is hidden with logged into an account with no suppression rights as seen in the screenshots below. I will move this to Done. Thanks for all your work!

Status: ✅PASS
Environment: Local: 1.41.0-alpha (ac546dd)15:31, 2 October 2023. Checkuser: 2.5 (99b7a3b) 11:11, 2 October 2023
OS: macOS Sonoma 14.0
Browser: Chrome 117, Firefox 117, Safari 17
Device: MBA M2
Emulated Device:: n/a
Test Links:
http://localhost:8080/w/index.php?title=Wawa
http://localhost:8080/wiki/Special:CheckUser

✅AC1: https://phabricator.wikimedia.org/T347773

Checkuser Acct OnlySuppressor Acct OnlyDelete Article w/Suppress CheckSpecial:Checkuser w/o SuppressSpecial:Checkuser w/ Suppress
2023-10-02_10-05-49.png (1×1 px, 196 KB)
2023-10-02_09-59-53.png (904×892 px, 135 KB)
2023-10-02_10-03-11.png (709×3 px, 191 KB)
2023-10-02_10-04-34.png (1×3 px, 312 KB)
2023-10-02_10-10-20.png (1×3 px, 309 KB)