Geo Analytics: Add project validation to manage the 'invalid characters' error (400 Bad Request)
Closed, ResolvedPublic1 Estimated Story Points
Actions

Assigned To

Authored By

	Sfaci
	Oct 3 2023, 10:16 AM

Description

Epic: T288305: AQS 2.0: Geo Analytics Service

Description

During the Sprint 01 we worked on a new function to validate project to manage the 'invalid characters' error (we missed it during the initial phase of the development). A function called ValidateProject was added to aqsassist to be used from a middleware function in all the services. We did it for some of them but this task was deferred because other services had been already deployed. geo-analytics was one of those services, so we still need to include this validation.

Acceptance Criteria

A middleware function has been created to validate project to manage the 'invalid characters' 400 error.

Required

Add new integration test cases for this new scenario (an invalid project is requested)
Run unit and integration tests after adding the new middleware function

Details

	Subject	Repo	Branch	Lines +/-
	Add Project Validation to Manage invalid characters error(400 Bad Request)	generated-data-platform/aqs/geo-analytics	main	+28 -2

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Stalled	None	T324931 Clean up open RESTBase related tickets
In Progress	None	T262315 <CORE TECHNOLOGY> API Migration & RESTbase Sunset
In Progress	None	T263489 AQS 2.0
Resolved	SGupta-WMF	T288305 AQS 2.0: Geo Analytics Service
Resolved	Sfaci	T347958 Geo Analytics: Add project validation to manage the 'invalid characters' error (400 Bad Request)

Event Timeline

Sfaci created this task.Oct 3 2023, 10:16 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 3 2023, 10:16 AM

Sfaci added a project: AQS2.0.Oct 3 2023, 10:17 AM

Sfaci moved this task from Incoming to Sprint 02 on the Data Products board.Oct 3 2023, 1:45 PM

Sfaci edited projects, added Data Products (Sprint 02); removed Data Products.

Sfaci triaged this task as Medium priority.Oct 3 2023, 2:05 PM

Sfaci added a subscriber: SGupta-WMF.Oct 6 2023, 5:58 AM

Sfaci added a parent task: T288305: AQS 2.0: Geo Analytics Service.Oct 6 2023, 6:21 AM

SGupta-WMF assigned this task to JEbe-WMF.Oct 6 2023, 7:03 AM

Sfaci updated the task description. (Show Details)Oct 10 2023, 4:18 PM

Sfaci mentioned this in T348565: Estimate Sprint 02 tasks - Santi.Oct 11 2023, 12:59 PM

WDoranWMF set the point value for this task to 1.Oct 17 2023, 11:10 AM

WDoranWMF moved this task from Sprint Backlog to Teleport to Sprint 03 on the Data Products (Sprint 02) board.Oct 24 2023, 12:56 PM

WDoranWMF edited projects, added Data Products (Data Products (Sprint 03)); removed Data Products (Sprint 02).

WDoranWMF moved this task from Sprint Backlog to Wormhole to Sprint 04 on the Data Products (Data Products (Sprint 03)) board.Nov 16 2023, 1:37 PM

WDoranWMF edited projects, added Data Products (Data Products Sprint 04); removed Data Products (Data Products (Sprint 03)).

JEbe-WMF moved this task from Sprint Backlog to In Process on the Data Products (Data Products Sprint 04) board.Nov 22 2023, 1:19 PM

Change 979027 had a related patch set uploaded (by Jennifer Ebe; author: Jennifer Ebe):

[generated-data-platform/aqs/geo-analytics@main] Add Project Validation to Manage invalid characters error(400 Bad Request)

https://gerrit.wikimedia.org/r/979027

gerritbot added a project: Patch-For-Review.Nov 30 2023, 9:41 AM

JEbe-WMF moved this task from In Process to Code Review / Tech Input on the Data Products (Data Products Sprint 04) board.Nov 30 2023, 9:42 AM

JEbe-WMF reassigned this task from JEbe-WMF to Surabhi_13692.Dec 5 2023, 1:11 PM

JEbe-WMF reassigned this task from Surabhi_13692 to SGupta-WMF.

JEbe-WMF added a subscriber: Surabhi_13692.

JEbe-WMF subscribed.

Change 979027 merged by Sg912:

[generated-data-platform/aqs/geo-analytics@main] Add Project Validation to Manage invalid characters error(400 Bad Request)

https://gerrit.wikimedia.org/r/979027

SGupta-WMF reassigned this task from SGupta-WMF to WDoranWMF.Dec 11 2023, 10:39 AM

SGupta-WMF moved this task from Code Review / Tech Input to Testing on the Data Products (Data Products Sprint 04) board.

SGupta-WMF removed a subscriber: Surabhi_13692.

Maintenance_bot removed a project: Patch-For-Review.Dec 11 2023, 11:10 AM

WDoranWMF reassigned this task from WDoranWMF to Sfaci.Dec 11 2023, 5:11 PM

WDoranWMF edited projects, added Data Products (Data Products Sprint 05); removed Data Products (Data Products Sprint 04).

WDoranWMF moved this task from Sprint Backlog to Testing on the Data Products (Data Products Sprint 05) board.

WDoranWMF subscribed.

unit and integration tests (the ones that are built in the project) work fine.
The new behaviour for this service doesn't seem to be included in the QA test suite so I have included two new scenarios to be able to test it. After that I have run all the scenarios and the service is responding fine for all of them (pending MR here to include the new ones to the QA test suite project -> https://gitlab.wikimedia.org/repos/generated-data-platform/aqs/aqs_tests/-/merge_requests/30). Could you review it @SGupta-WMF?

We can consider QA is passed

Sfaci updated the task description. (Show Details)Dec 12 2023, 10:33 AM

Sfaci moved this task from Testing to To Deploy on the Data Products (Data Products Sprint 05) board.

@Sfaci Reviewed and approved , feel free to merge this.

Thanks! It's merged.

So, the only pending task here is to deploy the service

Change 983160 had a related patch set uploaded (by Sg912; author: Sg912):

[operations/deployment-charts@master] Geo analytics image version change

https://gerrit.wikimedia.org/r/983160

gerritbot added a project: Patch-For-Review.Dec 14 2023, 11:23 AM

Change 983160 merged by jenkins-bot:

[operations/deployment-charts@master] Geo analytics image version change