Page MenuHomePhabricator

setMetadataValue Should Not Silently Ignore Degenerate ZObjects
Open, MediumPublicBUG REPORT

Description

Description

Steps to reproduce (step by step instructions, with links, commands and necessary data to reproduce the error)

  1. Call the function setMetadataValue with a degenerate object, e.g. Z22 = setMetadataValue( Z22, { 'Z1K1: 'Z6', Z6K1: 'key' }, { 'Z1K1: 'Z6', 'Z6K1': undefined } )

Observed behavior

  • the resulting Pair will look like { 'Z1K1': {...}, 'K1': { 'Z1K1': 'Z6', 'Z6K1': 'key' }, 'K2': { 'Z1K1': 'Z6' } }

Expected behavior/Acceptance criteria (returned value, expected error, performance expectations, etc.)

  • setMetadataValue should raise an error or otherwise indicate that the input was not a valid ZObject

Completion checklist