Page MenuHomePhabricator
Create Task
Maniphest T348398

Missing old/new_content_model variables on Flow pages
Open, Needs TriagePublic
Actions

Description

On page edits, AbuseFilter defines old_content_model and new_content_model variables, containing the content model of the page (wikitext, css, javascript, etc).

Flow pages have the flow-board content model. One would expect these pages to have in AbuseFilter the old_content_model and new_content_model variables with value flow-board. But currently these variables are not defined on Flow pages.

This caused an issue on frwiki, as I had added a new_content_model == 'flow-board' condition, which could never match…

Details

SubjectRepoBranchLines +/-
Define "old_content_model" and "new_content_model" variables on Flow pagesmediawiki/extensions/Flowmaster+11 -0
Customize query in gerrit

Event Timeline

Od1n created this task.Oct 8 2023, 11:42 AM
Restricted Application added a project: Growth-Team. · View Herald TranscriptOct 8 2023, 11:42 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
gerritbot added a comment.Oct 8 2023, 12:01 PM

Change 964181 had a related patch set uploaded (by Gerrit Patch Uploader; author: Anne Haunime):

[mediawiki/extensions/Flow@master] Define "old_content_model" and "new_content_model" variables on Flow pages

https://gerrit.wikimedia.org/r/964181

gerritbot added a project: Patch-For-Review.Oct 8 2023, 12:01 PM
Od1n added a comment.Oct 8 2023, 12:21 PM

By the way, Flow has a dedicated AbuseFilter group. See the wgFlowAbuseFilterGroup variable at Extension:StructuredDiscussions#Configuration.

Filters in this group are executed only on Flow pages, and conversely, filter in other groups (i.e. the default group) are not executed on Flow pages.

Though, as stated in the documentation linked above, it is possible to set this group to the special value 'default', to discard the segregation of Flow-related filters.

Etonkovidova moved this task from Inbox to Triaged on the Growth-Team board.Oct 13 2023, 9:50 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL