When reviewing an AbuseFilter log entry, I noticed its ID was num-formatted (i.e. separators between groups of digits).
This doesn't make sense here, as it is an identifier (just like a revision ID), not an amount.
When looking at the code, I noticed filter IDs were also num-formatted in some places.
(this issue easily went unnoticed, as there are usually less than 1,000 filters)
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Log entry IDs should not be num-formatted | mediawiki/extensions/AbuseFilter | master | +2 -2 |
Change 965462 had a related patch set uploaded (by Gerrit Patch Uploader; author: Anne Haunime):
[mediawiki/extensions/AbuseFilter@master] Filter IDs and log entry IDs should not be num-formatted
Uploaded patchset 3, which takes care of occurrences of formatNum() that were remaining.
It was a bit tricky:
Alternatively, we may play it safe for now: keep filter IDs num-formatted, and just cherry-pick the 2 changes for log entry IDs (see in SpecialAbuseLog.php).
@matej_suchanek I took the liberty of subscribing you here, as I mainly comment on Phabricator :)
Arguably, filter IDs could be considered as their "name". For instance, on frwiki we often refer to the filters just by their numbers.
I uploaded patchset 4, which keeps the filter IDs num-formatted, and only removes the num-formatting of log entry IDs, which undoubtedly should not be num-formatted, just as revision IDs.