Maniphest T348795

Implement StatsLib improvements
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	colewhite
	Oct 12 2023, 6:00 PM

Tags

Referenced Files

None

Subscribers

Description

Drop unused $labels parameter from CounterMetric->incrementBy()
Allow CounterMetric->IncrementBy() to accept a float value
Annotate TimingMetric->observe() with expected time unit (milliseconds)

Details

	Subject	Repo	Branch	Lines +/-
	Stats: allow floats to be provided to CounterMetric->incrementBy()	mediawiki/core	master	+2 -2
	Stats: update TimingMetric->observe() docstring	mediawiki/core	master	+3 -1
	Stats: remove unused $label parameter	mediawiki/core	master	+1 -2

Customize query in gerrit

Event Timeline

colewhite created this task.Oct 12 2023, 6:00 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 12 2023, 6:00 PM

Change 965145 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] Stats: remove unused $label parameter

https://gerrit.wikimedia.org/r/965145

gerritbot added a project: Patch-For-Review.Oct 12 2023, 7:21 PM

Change 965566 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] Stats: allow floats to be provided to CounterMetric->incrementBy()

https://gerrit.wikimedia.org/r/965566

Change 965567 had a related patch set uploaded (by Cwhite; author: Cwhite):

[mediawiki/core@master] Stats: update TimingMetric->observe() docstring

https://gerrit.wikimedia.org/r/965567

colewhite changed the task status from Open to In Progress.Oct 12 2023, 7:59 PM

colewhite claimed this task.

lmata added a project: SRE Observability (FY2023/2024-Q2).Oct 17 2023, 12:16 AM

Change 965145 merged by jenkins-bot:

[mediawiki/core@master] Stats: remove unused $label parameter

https://gerrit.wikimedia.org/r/965145

Change 965566 merged by jenkins-bot:

[mediawiki/core@master] Stats: allow floats to be provided to CounterMetric->incrementBy()

https://gerrit.wikimedia.org/r/965566

Change 965567 merged by jenkins-bot:

[mediawiki/core@master] Stats: update TimingMetric->observe() docstring

https://gerrit.wikimedia.org/r/965567

Maintenance_bot removed a project: Patch-For-Review.Oct 18 2023, 5:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 18 2023, 6:00 PM

Thanks, @aaron!

lmata moved this task from Inbox to Done on the SRE Observability (FY2023/2024-Q2) board.Jan 26 2024, 1:08 AM