Page MenuHomePhabricator

Video not appearing in embed mode
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce

  1. Open https://commons.wikimedia.org/wiki/File:Grey_squirrel_eating_from_bird_feeder.webm?embedplayer=yes
  2. Wait for the Video.js player to load
  3. Click the play icon

Actual result

  1. The sound plays, but the video doesn’t appear. (More precisely, the video appears with a 0×0px size.)

Expected result

  1. The video fills the screen/iframe.

Event Timeline

brooke subscribed.

Definitely regressions in the last few months since I last tested it, I'm adding this to my short-list for this week.

Its because the media object changes for figure. The element is now inside an unsized span.

Change 966911 had a related patch set uploaded (by TheDJ; author: TheDJ):

[mediawiki/extensions/TimedMediaHandler@master] Repair iframe mode of video, broken due to <figure> changes

https://gerrit.wikimedia.org/r/966911

Yep, that does it. :D Good catch!

Should be safe to backport the CSS fix to production branches, or we can let it roll out with the coming trains.

Change 966911 merged by jenkins-bot:

[mediawiki/extensions/TimedMediaHandler@master] Repair iframe mode of video, broken due to <figure> changes

https://gerrit.wikimedia.org/r/966911

Its been broken for weeks, i think we can wait a couple more days for the train to roll ;)