Page MenuHomePhabricator

RevisionSlider jumps to random positions after window resize event
Closed, ResolvedPublicBUG REPORT

Description

Steps to reproduce:

  1. Forward navigation
    • Resize your browser window and make it very narrow, e.g. half the screen.
    • Go to any page history, open any diff, enable the RevisionSlider, and ideally pin it.
    • Now make the browser window larger, i.e. trigger at least one resize event.
    • Click the "Previous edit" link.
    • Unexpected behavior: Instead of jumping 1 revision the slider starts to a random position multiple revisions away.
  2. Backward navigation
    • Resize your browser window and make it very narrow, e.g. half the screen.
    • Go to any page history, open any diff, enable the RevisionSlider, and ideally pin it.
    • Click the "Previous edit" link multiple times.
    • Now make the browser window larger, i.e. trigger at least one resize event.
    • Now use the browser's back button.
    • Unexpected behavior: Instead of jumping 1 revision the slider starts to a random position multiple revisions away.

Marking as a Regression because I believe this was not an issue before T139101.

Event Timeline

Change 966870 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Fix certain history events being triggered multiple times

https://gerrit.wikimedia.org/r/966870

Change 966870 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Fix certain history events being triggered multiple times

https://gerrit.wikimedia.org/r/966870

Change 968657 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/RevisionSlider@master] Clamp slider position when using the browser's back button

https://gerrit.wikimedia.org/r/968657

Change 968657 merged by jenkins-bot:

[mediawiki/extensions/RevisionSlider@master] Clamp slider position when using the browser's back button

https://gerrit.wikimedia.org/r/968657