Page MenuHomePhabricator
Create Task
Maniphest T349327

Audit PHPCSExtra to see if there are any sniffs we may want to add to our ruleset
Closed, ResolvedPublic
Actions

Description

Following up from T349153, we should audit the PHPCSExtra package to see if there are any sniffs that we may want to add to our ruleset. Universal.WhiteSpace.DisallowInlineTabs might be an example.

Details

SubjectRepoBranchLines +/-
Replace AlternativeSyntaxSniff with upstream sniffmediawiki/tools/codesniffermaster+125 -64
Replace ShortListSyntaxSniff with upstream sniffmediawiki/tools/codesniffermaster+14 -77
Enable the `Universal.WhiteSpace.CommaSpacing` sniffmediawiki/tools/codesniffermaster+37 -183
Add first batch of rules from the PHPCSExtra standardsmediawiki/tools/codesniffermaster+22 -1
Allow the `phpcodesniffer-composer-installer` composer pluginmediawiki/coremaster+2 -1
Customize query in gerrit

Related Objects

Event Timeline

Daimona created this task.Oct 19 2023, 4:53 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptOct 19 2023, 4:53 PM
Daimona mentioned this in T349153: Squiz.WhiteSpace.ScopeKeywordSpacing.Incorrect does not work with "private".Oct 19 2023, 4:53 PM
Daimona claimed this task.Oct 19 2023, 9:59 PM
gerritbot added a comment.Oct 19 2023, 10:24 PM

Change 967312 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/codesniffer@master] Add first batch of rules from the PHPCSExtra standards

https://gerrit.wikimedia.org/r/967312

gerritbot added a project: Patch-For-Review.Oct 19 2023, 10:24 PM
gerritbot added a comment.Oct 19 2023, 11:00 PM

Change 967315 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/codesniffer@master] Enable the `Universal.WhiteSpace.CommaSpacing` sniff

https://gerrit.wikimedia.org/r/967315

gerritbot added a comment.Oct 19 2023, 11:08 PM

Change 967316 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/core@master] Allow the `phpcodesniffer-composer-installer` composer plugin

https://gerrit.wikimedia.org/r/967316

gerritbot added a comment.Oct 19 2023, 11:23 PM

Change 967317 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/codesniffer@master] Replace ShortListSyntaxSniff with upstream sniff

https://gerrit.wikimedia.org/r/967317

gerritbot added a comment.Oct 19 2023, 11:39 PM

Change 967318 had a related patch set uploaded (by Daimona Eaytoy; author: Daimona Eaytoy):

[mediawiki/tools/codesniffer@master] Replace AlternativeSyntaxSniff with upstream sniff

https://gerrit.wikimedia.org/r/967318

gerritbot added a comment.Oct 20 2023, 5:44 PM

Change 967316 merged by jenkins-bot:

[mediawiki/core@master] Allow the `phpcodesniffer-composer-installer` composer plugin

https://gerrit.wikimedia.org/r/967316

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.2; 2023-10-24).Oct 20 2023, 6:00 PM
gerritbot added a comment.Oct 20 2023, 9:49 PM

Change 967312 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Add first batch of rules from the PHPCSExtra standards

https://gerrit.wikimedia.org/r/967312

gerritbot added a comment.Oct 20 2023, 9:52 PM

Change 967315 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Enable the `Universal.WhiteSpace.CommaSpacing` sniff

https://gerrit.wikimedia.org/r/967315

gerritbot added a comment.Oct 20 2023, 9:53 PM

Change 967317 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Replace ShortListSyntaxSniff with upstream sniff

https://gerrit.wikimedia.org/r/967317

gerritbot added a comment.Oct 20 2023, 9:54 PM

Change 967318 merged by jenkins-bot:

[mediawiki/tools/codesniffer@master] Replace AlternativeSyntaxSniff with upstream sniff

https://gerrit.wikimedia.org/r/967318

Maintenance_bot removed a project: Patch-For-Review.Oct 20 2023, 10:10 PM
Daimona closed this task as Resolved.Oct 21 2023, 3:39 PM

Let's call this done for now. There are a couple more sniffs I'd like to enable but that need more work, so I'm going to create follow-up tasks for them.

Reedy mentioned this in T358956: Phpcs complaining about Universal.Constants.LowercaseClassResolutionKeyword not existing.Mar 2 2024, 5:57 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL