Page MenuHomePhabricator
Create Task
Maniphest T349497

User rights: wikilambda-create-boolean and wikilambda-create-unit are unused
Closed, ResolvedPublicBUG REPORT
Actions

Description

Description

Creation of boolean and unit types should be tightly protected, any attempt to create a boolean or a unit instance should be stopped by "wikilambda-create-boolean" and "wikilambda-create-unit".

However, these two rights are not being captured by "getRequiredCreateRights" method (See https://gerrit.wikimedia.org/r/plugins/gitiles/mediawiki/extensions/WikiLambda/+/refs/heads/master/includes/Authorization/ZObjectAuthorization.php#78)

Completion checklist

Details

SubjectRepoBranchLines +/-
Add permission checks for bool, unitmediawiki/extensions/WikiLambdamaster+55 -8
Customize query in gerrit

Event Timeline

gengh created this task.Oct 23 2023, 11:41 AM
Jdforrester-WMF subscribed.Oct 23 2023, 8:12 PM

WIP: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/WikiLambda/+/944214

gerritbot added a comment.Oct 25 2023, 10:37 PM

Change 944214 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/extensions/WikiLambda@master] WIP: Add permission checks for bool, unit

https://gerrit.wikimedia.org/r/944214

gerritbot added a project: Patch-For-Review.Oct 25 2023, 10:37 PM
Jdforrester-WMF changed the task status from Open to In Progress.Oct 26 2023, 4:40 PM
Jdforrester-WMF triaged this task as Medium priority.
Jdforrester-WMF moved this task from To triage to In Progress on the Abstract Wikipedia team board.
Jdforrester-WMF claimed this task.Nov 6 2023, 8:46 PM
gerritbot added a comment.Dec 1 2023, 8:57 AM

Change 944214 merged by jenkins-bot:

[mediawiki/extensions/WikiLambda@master] Add permission checks for bool, unit

https://gerrit.wikimedia.org/r/944214

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.9; 2023-12-12).Dec 1 2023, 9:00 AM
Maintenance_bot removed a project: Patch-For-Review.Dec 1 2023, 9:10 AM
Jdforrester-WMF moved this task from In Progress to To deploy on the Abstract Wikipedia team board.Dec 1 2023, 2:36 PM
Jdforrester-WMF closed this task as Resolved.Dec 12 2023, 4:05 PM
Jdforrester-WMF moved this task from To deploy to Verify in production on the Abstract Wikipedia team board.Jan 22 2024, 8:01 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits