Page MenuHomePhabricator

Upload size warning doesn't show actual setting
Closed, ResolvedPublic

Description

Author: mapellegrini

Description:
While working on the upload script, serveral of the ogg files I uploaded failed
to save properly. The reason is because it was given the following erronious
prompt:

Upload warning

  • It is recommended that images not exceed 100k in size.

I attempted to upload manually in a web-browser, and got the same error. Just to
be sure that the file wasn't be misidentified, I ran the file command on it:

[mark@localhost ~/script]$ file ../ogg/schubert-mass_in_g._6._agnus_dei.ogg
../ogg/schubert-mass_in_g._6._agnus_dei.ogg: Ogg data, Vorbis audio,


Version: unspecified
Severity: minor

Details

Reference
bz1506
TitleReferenceAuthorSource BranchDest Branch
Scap Backport: fix scap hang on patches marked with -2repos/releng/scap!231sandeepsT350628-fix-backport-hangs-issuemaster
Use orchestrator_recursion_limit in execute.jsrepos/abstract-wiki/wikifunctions/function-orchestrator!88dmartinT350608main
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/wikilambda-cli!19dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/function-orchestrator!85dmartinsync-function-schematamain
Update function-schemata sub-module to HEAD (17c4936)repos/abstract-wiki/wikifunctions/function-evaluator!104dmartinsync-function-schematamain
remove deleted mathoid test project and improve error logrepos/releng/gitlab-trusted-runner!49jeltoremove-mathoid-testmain
add error handling for adding and delete projectsrepos/releng/gitlab-trusted-runner!48jeltoadd-error-handling-deleted-projectmain
Explicitly use echo -e to force backslash-interpretationrepos/sre/wmf-debci!3mvernonfix_apt_preferencesmain
If USEBACKPORTS set, tell apt to use the relevant -backports suiterepos/sre/wmf-debci!2mvernonT350658main
definitions: Add recursion limit error types Z572 for orchestrator and Z573 for evaluatorrepos/abstract-wiki/wikifunctions/function-schemata!52dmartinT350608main
Customize query in GitLab

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 8:12 PM
bzimport set Reference to bz1506.
bzimport added a subscriber: Unknown Object (MLST).

Changed summary to reflect the problem described; Wikimedia sites have the warning moved up from the default 150k to 5
million bytes, but the 'largefile' warning message has 100k hardcoded. Instead of a hardcoded value, the message should
probably display the actual $wgUploadSizeWarning setting, or some relative of it.

avarab wrote:

Marking it as FIXED.

The current code in CVS is unreasonably specific, giving a to-the-byte value.

robchur wrote:

You're saying report it in MB or something, or allow a margin one way or another?

robchur wrote:

Reclosing in favour of more specific 8214.