Page MenuHomePhabricator
Create Task
Maniphest T350968

Use expression builder instead of raw SQL in AbuseFilter
Closed, ResolvedPublic
Actions

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Use expression builder to avoid IDatabase::makeListmediawiki/extensions/AbuseFiltermaster+23 -20
Use expression builder instead of raw sqlmediawiki/extensions/AbuseFiltermaster+9 -8
Use expression builder in AbuseFilterView::buildTestConditionsmediawiki/extensions/AbuseFiltermaster+36 -62
Use expression builder to build where conditionsmediawiki/extensions/AbuseFiltermaster+7 -7
Use SelectQueryBuilder for sub queries in migrateActorsAF.phpmediawiki/extensions/AbuseFiltermaster+18 -15
Use IReadableDatabase::expr for complex conditions on Special:AbuseLogmediawiki/extensions/AbuseFiltermaster+19 -20
Customize query in gerrit

Related Objects
Search...

Event Timeline

Maintenance_bot created this task.Nov 10 2023, 4:24 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 10 2023, 4:24 PM
Ladsgroup added a project: AbuseFilter.Nov 10 2023, 5:10 PM
Ladsgroup added a project: MediaWiki CodeJam Dec 2023.Dec 5 2023, 4:48 PM
• FJoseph-WMF moved this task from Incoming to Cleanup / Tech Debt on the MediaWiki CodeJam Dec 2023 board.Dec 5 2023, 8:33 PM
gerritbot added a comment.May 17 2024, 8:20 PM

Change #1032859 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use IReadableDatabase::expr for complex conditions on Special:AbuseLog

https://gerrit.wikimedia.org/r/1032859

gerritbot added a project: Patch-For-Review.May 17 2024, 8:20 PM
gerritbot added a comment.May 18 2024, 1:40 PM

Change #1033174 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use SelectQueryBuilder for sub queries in migrateActorsAF.php

https://gerrit.wikimedia.org/r/1033174

gerritbot added a comment.May 22 2024, 4:24 AM

Change #1032859 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use IReadableDatabase::expr for complex conditions on Special:AbuseLog

https://gerrit.wikimedia.org/r/1032859

ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).May 22 2024, 5:00 AM
gerritbot added a comment.May 22 2024, 8:07 AM

Change #1033174 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use SelectQueryBuilder for sub queries in migrateActorsAF.php

https://gerrit.wikimedia.org/r/1033174

Maintenance_bot removed a project: Patch-For-Review.May 22 2024, 8:30 AM
gerritbot added a comment.May 22 2024, 8:01 PM

Change #1035030 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use expression builder in AbuseFilterView::buildTestConditions

https://gerrit.wikimedia.org/r/1035030

gerritbot added a project: Patch-For-Review.May 22 2024, 8:01 PM
gerritbot added a comment.May 30 2024, 9:10 AM

Change #1037445 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use expression builder to replace addQuotes

https://gerrit.wikimedia.org/r/1037445

gerritbot added a comment.Jun 9 2024, 3:45 AM

Change #1037445 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use expression builder to build where conditions

https://gerrit.wikimedia.org/r/1037445

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.9; 2024-06-11); removed MW-1.43-notes (1.43.0-wmf.7; 2024-05-28).Jun 9 2024, 4:00 AM
gerritbot added a comment.Jun 17 2024, 7:55 PM

Change #1035030 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use expression builder in AbuseFilterView::buildTestConditions

https://gerrit.wikimedia.org/r/1035030

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.10; 2024-06-18); removed MW-1.43-notes (1.43.0-wmf.9; 2024-06-11).Jun 17 2024, 8:00 PM
Maintenance_bot removed a project: Patch-For-Review.Jun 17 2024, 8:31 PM
gerritbot added a comment.Jul 21 2024, 3:18 PM

Change #1055585 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use expression builder to avoid IDatabase::makeList

https://gerrit.wikimedia.org/r/1055585

gerritbot added a project: Patch-For-Review.Jul 21 2024, 3:18 PM
gerritbot added a comment.Jul 21 2024, 8:08 PM

Change #1055616 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055616

gerritbot added a comment.Jul 22 2024, 8:48 PM

Change #1055616 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use expression builder instead of raw sql

https://gerrit.wikimedia.org/r/1055616

ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.15; 2024-07-23); removed MW-1.43-notes (1.43.0-wmf.10; 2024-06-18).Jul 22 2024, 9:00 PM
gerritbot added a comment.Jul 26 2024, 6:44 PM

Change #1055585 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] Use expression builder to avoid IDatabase::makeList

https://gerrit.wikimedia.org/r/1055585

Umherirrender closed this task as Resolved.Jul 26 2024, 6:54 PM
Umherirrender claimed this task.
Umherirrender removed a project: Patch-For-Review.
ReleaseTaggerBot edited projects, added MW-1.43-notes (1.43.0-wmf.16; 2024-07-30); removed MW-1.43-notes (1.43.0-wmf.15; 2024-07-23).Jul 26 2024, 7:00 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits