Page MenuHomePhabricator

Use expression builder instead of raw SQL in Nuke
Closed, ResolvedPublic

Description

Now that T210206: Deprecate raw SQL conditions for IDatabase methods (select, insert, etc.) is done, this extension should migrate away from building and passing around raw SQL to expression builders.

It improves readability and security of the code and is more aligned with industry practices easing onboarding.

For more information check T210206 and T350075.

Calls to Database::addQuotes(), ::buildLike(), ::makeList() indicate that raw SQL is being built and passed around.

Event Timeline

Change 984224 had a related patch set uploaded (by Ladsgroup; author: Amir Sarabadani):

[mediawiki/extensions/Nuke@master] Migrate to query builder and expression builders

https://gerrit.wikimedia.org/r/984224

Change 984224 merged by jenkins-bot:

[mediawiki/extensions/Nuke@master] Migrate to query builder and expression builders

https://gerrit.wikimedia.org/r/984224

Ladsgroup claimed this task.