I think we might want to keep pytest outside of pre-commit, we kept it out for the reasons mentioned here: https://github.com/pre-commit/pre-commit-hooks/issues/291

There's also better control of the dependencies (versions of pytest, python, ...) from tox afaik

But I'm willing to change my mind, so send a patch if you think otherwise and we can check :)

In T351476#9395817, @dcaro wrote:

I think we might want to keep pytest outside of pre-commit, we kept it out for the reasons mentioned here: https://github.com/pre-commit/pre-commit-hooks/issues/291

There's also better control of the dependencies (versions of pytest, python, ...) from tox afaik

But I'm willing to change my mind, so send a patch if you think otherwise and we can check :)

@dcaro I looked at the issue you linked and it seems to be talking about why their is not official pytest pre-commit hook (like the way we have black and flake8). Although it did mention the other issue of tests being slow, but I don't think that applies to us since our tests are not necessarily slow. I think they did recommended a way to add pytest to pre-commit (that you have to add yourself) which is kind of variation of the local approach. Will try out their approach too