Page MenuHomePhabricator

Remember termbox collapse state for not-logged-in users
Closed, ResolvedPublic

Description

Problem:
The collapse state of the termbox is remembered for logged-in editors but not for non-logged-in users. It should be remembered for them as well.

Example:
For non-logged-in users, we should remember the collapse state of the termbox so that they have a consistent user experience each time they visit an Item or Property page.

What happens

  • In a private browser window visit: https://www.wikidata.org/wiki/Q42
  • Click in more languages to collapse the state of the termbox
  • Refresh the page
  • The termbox reappears in it's open state

What should happen

  • In a private browser window visit: https://www.wikidata.org/wiki/Q42
  • Click in more languages to collapse the state of the termbox
  • Refresh the page
  • The termbox reappears in it's collapsed state

Screenshots

Open state

image.png (389×1 px, 50 KB)

Collapsed state

image.png (104×1 px, 9 KB)

BDD
GIVEN an Item or Property page
AND a non-logged-in user
WHEN opening another Item or Property
THEN the collapse state of the termbox should be remembered from the previous Item or Property

Acceptance criteria:

  • collapse state of termbox is stored across Item/Property pages for non-logged-in users just as it does for logged-in editors

Event Timeline

Hi @Arian_Bozorg,

I had a look here at the reproduction steps, and I was able to reproduce the behaviour you describe on beta for users with Temporary Accounts. That said, I see exactly the same behaviour in production for Anonymous / IP Users. Do you see the same thing? Is this feature related only to Temporary Accounts, or do you want this addressed for all non-logged-in users?

Thanks so much for picking up on that Arthur. Yes, this would be a feature that would benefit all non-logged in users.

I will update the ticket to reflect the changes.

If I understand it right, this ticket no longer has anything to do with IP Masking, except that whoever implements the feature should consider both anonymous (IP) users and temporary users. It would then not belong as a child of T351968. Does it still have the same priority as the other tickets that are actually impacted by IP-Masking?

Hi @Arian_Bozorg , @Lydia_Pintscher , @ItamarWMDE ,

Can any of you comment on the priority for this ticket?

Yes, you're right I think it would be good to deprioritise below the IP masking. But while we are here let's solve this for all non-logged-in users.

Moved back into backlog for now so the team can focus on IP masking. What is the prio against MUL?

Thanks for moving it back out, let's keep it above MUL

ArthurTaylor renamed this task from Remember termbox collapse state for temporary accounts to Remember termbox collapse state for not-logged-in users.Feb 2 2024, 10:51 AM
ArthurTaylor removed a project: wmde-wikidata-tech.

Removed the label wmde-wikidata-tech because this seems to be a product rather than a tech task, and we weren't able to find a suitable label for it in Itamar's Tech Backlog Grooming guide

Change 998394 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Render expand/collapse of entitytermslist locally for anon users

https://gerrit.wikimedia.org/r/998394

Change 998394 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Render expand/collapse of entitytermslist locally for anon users

https://gerrit.wikimedia.org/r/998394

This seems to have solved it in my testing on beta \o/
Just one small issue: by default it seems to start with a collapsed termbox. I think if nothing has been set we should have it be uncollapsed like before.

Change 1004026 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] List-language termbox should be visble by default

https://gerrit.wikimedia.org/r/1004026

@Lydia_Pintscher Thanks for the feedback - good catch. I've pushed another patch to address the default behaviour. We'll try and get that merged today so that both changes make the train.

Change 1004026 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] List-language termbox should be visble by default

https://gerrit.wikimedia.org/r/1004026

Lydia_Pintscher claimed this task.

Perfect! \o/ Thank you.

Change 1007558 had a related patch set uploaded (by Arthur taylor; author: Arthur taylor):

[mediawiki/extensions/Wikibase@master] Add strict_types to changed files

https://gerrit.wikimedia.org/r/1007558

Change 1007558 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add strict_types to changed files

https://gerrit.wikimedia.org/r/1007558