Page MenuHomePhabricator
Create Task
Maniphest T352416

Make UnicodePluralValidator more strict
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

While reviewing translation imports, I noticed some incorrect plural translations have went through: https://translatewiki.net/w/i.php?title=Wikimedia:Wikipedia-android-strings-search_results_count/dag&action=edit&oldid=12052045

It seems dga doesn't have plural rules in CLDR, so the current code skips all the validations. We can improve that to only skip some validations.

See also https://github.com/wikimedia/apps-android-wikipedia/pull/4304/commits/c8604ab13790c81166e1c012691473ccdaf15089

Details

SubjectRepoBranchLines +/-
Make UnicodePluralValidator strictermediawiki/extensions/Translatemaster+62 -43
Customize query in gerrit

Event Timeline

Nikerabbit created this task.Nov 30 2023, 12:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptNov 30 2023, 12:40 PM
gerritbot added a comment.Nov 30 2023, 12:41 PM

Change 979052 had a related patch set uploaded (by Nikerabbit; author: Nikerabbit):

[mediawiki/extensions/Translate@master] Make UnicodePluralValidator stricter

https://gerrit.wikimedia.org/r/979052

gerritbot added a project: Patch-For-Review.Nov 30 2023, 12:41 PM
Nikerabbit triaged this task as Low priority.Nov 30 2023, 12:41 PM
Nikerabbit set the point value for this task to 2.
Nikerabbit moved this task from Quarter Backlog to In Review on the Language-Team (Language-2023-October-December) board.
Nikerabbit updated the task description. (Show Details)Nov 30 2023, 12:44 PM
abi_ assigned this task to Nikerabbit.Dec 7 2023, 4:13 AM
gerritbot added a comment.Dec 12 2023, 4:25 AM

Change 979052 merged by jenkins-bot:

[mediawiki/extensions/Translate@master] Make UnicodePluralValidator stricter

https://gerrit.wikimedia.org/r/979052

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.10; 2023-12-19).Dec 12 2023, 5:00 AM
abi_ moved this task from In Review to Check after deployment on the Language-Team (Language-2023-October-December) board.Dec 12 2023, 5:46 AM
Nikerabbit moved this task from Backlog to Support (LM) on the Localization Infrastructure FY2023-24 board.Dec 12 2023, 11:39 AM
abi_ closed this task as Resolved.Dec 13 2023, 8:22 AM
abi_ moved this task from Check after deployment to Done on the Language-Team (Language-2023-October-December) board.
abi_ subscribed.

Works well:

image.png (953×1 px, 129 KB)

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL