Page MenuHomePhabricator
Create Task
Maniphest T352769

Automoderator should be able to revert edits based on Revert Risk scores from the ORES extension
Open, In Progress, LowPublic5 Estimated Story Points
Actions

Description

In T352439 we implemented a simple approach to reverting which directly uses the Liftwing API.
Ultimately what we're looking for is to be able to get edit scores from the Revert Risk model in the ORES extension so that we can scale better in production and batch our requests.

Acceptance criteria

Given the ORES extension is loaded/configured to use the Revert Risk model and the revision has been scored, Automoderator should fetch Revert Risk scores from it instead of the Liftwing API.
This will be a lookup to get score from the database.

Details

SubjectRepoBranchLines +/-
Revert edits based on revert risk scores in ORESmediawiki/extensions/AutoModeratormaster+950 -45
Zuul: [mediawiki/extensions/Automoderator] Add ORES as a dependencyintegration/configmaster+2 -0
Create Talk Page message sender classmediawiki/extensions/AutoModeratormaster+367 -136
Naive reverts based on revertrisk scoremediawiki/extensions/AutoModeratormaster+9 K -0
Customize query in gerrit

Related Objects

Event Timeline

Samwalton9-WMF created this task.Dec 5 2023, 2:21 PM
Samwalton9-WMF removed a parent task: T352437: Create Automoderator's edit reverting functionality.
Samwalton9-WMF added a subtask: T348298: Add revertrisk-language-agnostic to RecentChanges filters.
Samwalton9-WMF added a parent task: T352437: Create Automoderator's edit reverting functionality.
Samwalton9-WMF moved this task from Backlog to Reverting on the Automoderator board.Dec 20 2023, 11:16 AM
gerritbot added a comment.Jan 23 2024, 9:36 PM

Change 992534 had a related patch set uploaded (by Jsn.sherman; author: Jsn.sherman):

[mediawiki/extensions/AutoModerator@master] Naive reverts based on revertrisk score

https://gerrit.wikimedia.org/r/992534

gerritbot added a project: Patch-For-Review.Jan 23 2024, 9:36 PM
PatchDemoBot added a comment.Feb 7 2024, 9:00 PM

Test wiki created on Patch demo by JSherman (WMF) using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/cf2b47d888/w

gerritbot added a comment.Feb 8 2024, 2:36 AM

Change 992534 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Naive reverts based on revertrisk score

https://gerrit.wikimedia.org/r/992534

jsn.sherman mentioned this in rEAMOad45137e4043: Naive reverts based on revertrisk score.Feb 8 2024, 2:37 AM
Maintenance_bot removed a project: Patch-For-Review.Feb 8 2024, 3:30 AM
Samwalton9-WMF updated the task description. (Show Details)Feb 9 2024, 12:22 PM
Samwalton9-WMF triaged this task as High priority.Feb 22 2024, 2:53 PM
Samwalton9-WMF removed a subtask: T348298: Add revertrisk-language-agnostic to RecentChanges filters.Feb 23 2024, 2:44 PM
jsn.sherman removed a parent task: T352437: Create Automoderator's edit reverting functionality.Mar 21 2024, 5:29 PM

Removed parent task to take it out of the pilot task graph since we decided not to depend on ORES for this pilot in T359050: Investigate hard ORES dependency for AutoModerator pilot

jsn.sherman lowered the priority of this task from High to Low.Mar 21 2024, 5:31 PM
jsn.sherman merged a task: T358344: Enable Language-agnostic revert risk model in ORES for Indonesian Wikipedia.Mar 21 2024, 6:08 PM
jsn.sherman added a subscriber: calbon.
Samwalton9-WMF moved this task from Inbox to Product backlog on the Moderator-Tools-Team board.Apr 8 2024, 11:36 AM
jsn.sherman renamed this task from Enable Automoderator to revert edits based on Revert Risk scores from the ORES extension to Automoderator should be able to revert edits based on Revert Risk scores from the ORES extension.Jun 10 2024, 6:32 PM
jsn.sherman moved this task from Product backlog to To be estimated on the Moderator-Tools-Team board.Jul 8 2024, 6:21 PM
Kgraessle updated the task description. (Show Details)Jul 8 2024, 9:16 PM
Kgraessle updated the task description. (Show Details)Jul 8 2024, 9:21 PM
Kgraessle updated the task description. (Show Details)Jul 8 2024, 9:40 PM
Kgraessle updated the task description. (Show Details)
Scardenasmolinar updated the task description. (Show Details)Jul 8 2024, 11:52 PM
Scardenasmolinar set the point value for this task to 5.Jul 9 2024, 3:13 PM
Scardenasmolinar moved this task from To be estimated to Up next on the Moderator-Tools-Team board.
DMburugu moved this task from Up next to Kanban on the Moderator-Tools-Team board.Jul 9 2024, 4:15 PM
DMburugu edited projects, added Moderator-Tools-Team (Kanban); removed Moderator-Tools-Team.
Scardenasmolinar changed the task status from Open to In Progress.Jul 10 2024, 12:31 AM
Scardenasmolinar claimed this task.
Scardenasmolinar moved this task from Ready to In Progress on the Moderator-Tools-Team (Kanban) board.
gerritbot added a comment.Jul 17 2024, 3:09 AM

Change #1054691 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Revert edits based on revert risk scores in ORES

https://gerrit.wikimedia.org/r/1054691

gerritbot added a project: Patch-For-Review.Jul 17 2024, 3:09 AM
Scardenasmolinar moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 20 2024, 1:36 AM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jul 22 2024, 3:43 PM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 23 2024, 7:09 PM
jsn.sherman moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Jul 24 2024, 1:07 AM
Scardenasmolinar moved this task from Reviewed (waiting for changes) to In Progress on the Moderator-Tools-Team (Kanban) board.Jul 25 2024, 1:15 AM

Moving this back to In Progress because there is a lot more work to do.

Kgraessle moved this task from In Progress to Eng review on the Moderator-Tools-Team (Kanban) board.Jul 30 2024, 2:42 PM
Kgraessle subscribed.Jul 31 2024, 7:38 PM

I got a chance to review your changes, and I think they look good! No nits or suggestions from me.

gerritbot added a comment.Jul 31 2024, 8:11 PM

Change #1058685 had a related patch set uploaded (by Scardenasmolinar; author: Scardenasmolinar):

[mediawiki/extensions/AutoModerator@master] Create Talk Page message sender class

https://gerrit.wikimedia.org/r/1058685

Scardenasmolinar added a comment.Jul 31 2024, 8:16 PM
In T352769#10033480, @Kgraessle wrote:

I got a chance to review your changes, and I think they look good! No nits or suggestions from me.

Thanks! A review on the new patch would also be appreciated! :)

gerritbot added a comment.Aug 1 2024, 6:48 PM

Change #1058685 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] Create Talk Page message sender class

https://gerrit.wikimedia.org/r/1058685

Scardenasmolinar mentioned this in rEAMO94df9eedde37: Create Talk Page message sender class.Aug 1 2024, 6:48 PM
ReleaseTaggerBot added a project: MW-1.43-notes (1.43.0-wmf.17; 2024-08-06).Aug 1 2024, 7:00 PM
gerritbot added a comment.Aug 9 2024, 7:46 AM

Change #1060513 had a related patch set uploaded (by Jforrester; author: Scardenasmolinar):

[integration/config@master] Zuul: [mediawiki/extensions/Automoderator] Add ORES as a dependency

https://gerrit.wikimedia.org/r/1060513

gerritbot added a comment.Aug 9 2024, 7:50 AM

Change #1060513 merged by jenkins-bot:

[integration/config@master] Zuul: [mediawiki/extensions/Automoderator] Add ORES as a dependency

https://gerrit.wikimedia.org/r/1060513

Stashbot added a comment.Aug 9 2024, 7:51 AM

Mentioned in SAL (#wikimedia-releng) [2024-08-09T07:51:39Z] <James_F> Zuul: [mediawiki/extensions/Automoderator] Add ORES as a dependency, for T352769

Samwalton9-WMF mentioned this in T372298: [SPIKE]Perform a load test for Multilingual Revert Risk on LiftWing[4H].Tue, Aug 13, 2:50 PM
Kgraessle moved this task from Eng review to Reviewed (waiting for changes) on the Moderator-Tools-Team (Kanban) board.Mon, Aug 19, 4:52 PM
Kgraessle moved this task from Reviewed (waiting for changes) to Eng review on the Moderator-Tools-Team (Kanban) board.Mon, Aug 19, 8:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits