1) phpunit_FixturesTest::testFixture with data set "Fixtures/lessjs-2.5.3 import-interpolation" (…) Standard compiler Failed asserting that two strings are identical. --- Expected +++ Actual @@ @@ -'body { - width: 100%; -} -#logo { - width: 100px; - height: 100px; - background: url('../assets/logo.png'); - background: url("#inline-svg"); -} - -.a { - var: test; -}' +'variable @in is undefined in import-interpolation.less on line 5, column 9 +3| @import "import/import-@{my_theme}-e.less"; +4| +5| @import "import/import-@{in}@{terpolation}.less"; +6| +7| @import "import/interpolation-vars.less"; +8|'
Description
Description
Details
Details
Customize query in gerrit
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T288498 Update less.php port to support Less.js 3.13 behaviours | |||
| Resolved | Hokwelum | T365481 Update less.php port to complete support Less.js 2.5.3 behaviours | |||
| Resolved | Hokwelum | T353133 Investigate test case for "${in}${terpolotation}" and "iterated-interpolation" (import-interpolation.less test case) |
Event Timeline
Comment Actions
Change 1005100 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/libs/less.php@master] docs: Write "Overview" and "Compatibility" in CONTRIBUTING.md
Comment Actions
Change 1005131 had a related patch set uploaded (by Krinkle; author: Krinkle):
[mediawiki/libs/less.php@master] Parser,Environment: Reduce various internal use of static state
Comment Actions
I thought this would be a quick one, but my local patch is getting quite large already. Hannah expressed interest in doing this one so I'll hand it over to you!
- [1.4.0] Add import visitor
- Implement ImportVisitor.
- Change Parser.parse to apply ImportVisitor.
https://github.com/less/less.js/commit/39f669e83c
- [1.4.0] Move importing into visitor
- Move logic from less.tree.Import to ImportVisitor.
https://github.com/less/less.js/commit/e63c8c5868
- [1.4.0] import interpolation finished.
- refactored the import phase to occur only within the import visitor, so that the import eval env can be passed between imports.
- Implement finish callback in ImportVisitor
- Change Parser.parse to apply ImportVisitor later, and pass the finish callback.
https://github.com/less/less.js/commit/5d54af2039
- [2.0.0] fix import sequencing
- Implement Import.prototype.isVariableImport and Quoted.prototype.containsVariables.
- Change Ruleset.prototype.variables to handle imported variables.
- Implement ImportSequencer.
- Change ImportVisitor to use the new ImportSequencer.
https://github.com/less/less.js/pull/2246/files
I've pushed a few smaller patches just now that improve the documentation and get a few things into place before these big changes.
Comment Actions
Change 1005100 merged by jenkins-bot:
[mediawiki/libs/less.php@master] docs: Write "Overview" and "Compatibility" in CONTRIBUTING.md
Comment Actions
Change 1005131 merged by jenkins-bot:
[mediawiki/libs/less.php@master] Parser,Environment: Reduce various internal use of static state
Comment Actions
Change 1007622 had a related patch set uploaded (by Hokwelum; author: Hokwelum):
[mediawiki/libs/less.php@master] Import Visitor
Comment Actions
Change 1007622 merged by jenkins-bot:
[mediawiki/libs/less.php@master] Implement ImportVisitor to support interpolated variable imports