Page MenuHomePhabricator
Create Task
Maniphest T353508

Special:NewPagesFeed "Were created by" filter doesn't work if you don't click anything in the dropdown list
Closed, ResolvedPublicBUG REPORT
Actions

Description

Steps to replicate the issue (include links if applicable):

  • Special:NewPagesFeed
  • Set filters
  • Type "Novem Linguae" into the "Were created by [ ]" text box
  • A drop down list of names will appear. Don't click any of them. Instead click somewhere on the modal.
  • Then click "Set filters"

image.png (1×1 px, 172 KB)

What happens?:

  • All articles displayed

What should have happened instead?:

  • Only Novem Linguae's articles should be displayed

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

Details

SubjectRepoBranchLines +/-
Fix 'were created by' filter problem in NewPagesFeedmediawiki/extensions/PageTriagemaster+1 -0
Customize query in gerrit

Related Objects

Event Timeline

Novem_Linguae created this task.Dec 15 2023, 9:53 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 15 2023, 9:53 AM
Novem_Linguae moved this task from Backlog to Vue migration bugs on the PageTriage board.Dec 15 2023, 9:55 AM
Novem_Linguae closed this task as a duplicate of T351480: Special:NewPagesFeed filter were created by username requires you to click on a username in the drop down list, or it will forget what you typed/pasted.Dec 15 2023, 4:05 PM
Novem_Linguae reopened this task as Open.Dec 15 2023, 4:10 PM

Changed my mind. This is a slightly different bug than T351480. The difference is that I think "type a name" -> "set filters" is now fixed, but "type a name" -> click the modal in a random spot -> "set filters" is not.

gerritbot added a comment.Mar 13 2024, 7:15 PM

Change 1010685 had a related patch set uploaded (by Maunikashekar; author: Maunikashekar):

[mediawiki/extensions/PageTriage@master] Fix 'were created by' filter problem in NewPagesFeed

https://gerrit.wikimedia.org/r/1010685

gerritbot added a project: Patch-For-Review.Mar 13 2024, 7:16 PM
Maunikashekar claimed this task.Mar 13 2024, 7:16 PM
PatchDemoBot added a comment.Mar 14 2024, 10:36 AM

Test wiki created on Patch demo by MPGuy2824 using patch(es) linked to this task:
https://patchdemo.wmflabs.org/wikis/d8f127a89e/w

MPGuy2824 subscribed.Mar 14 2024, 10:44 AM

@Novem_Linguae this seems fixed to me on enwiki. Can you check?

Novem_Linguae closed this task as Resolved.Mar 14 2024, 12:35 PM

Yeah, looks fixed to me to. Must have accidentally fixed this in a different patch. Marking as resolved.

gerritbot added a comment.Mar 14 2024, 12:42 PM

Change 1010685 abandoned by Maunikashekar:

[mediawiki/extensions/PageTriage@master] Fix 'were created by' filter problem in NewPagesFeed

Reason:

Issue already fixed as part of a different patch

https://gerrit.wikimedia.org/r/1010685

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2024, 1:30 PM
PatchDemoBot added a comment.Sun, Apr 14, 2:34 AM

Test wiki on Patch demo by MPGuy2824 using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/d8f127a89e/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL