Page MenuHomePhabricator
Create Task
Maniphest T353701

[builds-cli,builds-api] `build quota` fails if tool has no builds
Open, Stalled, MediumPublicBUG REPORT
Actions

Description

If a tool has no builds (and thus no harbor namespace), toolforge build quota fails with:

tools.taavi-test-tool@tools-sgebastion-11:~$ toolforge build quota
BuildClientError: Error getting quota from Harbor: failed to get harbor quota, status code: 403
Please report this issue to the Toolforge admins if it persists: https://w.wiki/6Zuu

builds-api logs aren't very helpful, but harbor logs do have this:

2023-12-19T13:46:08Z [ERROR] [/server/v2.0/handler/base.go:87]: failed to get project tool-taavi-test-tool: project tool-taavi-test-tool not found
2023-12-19T13:46:08Z [WARNING] [/common/rbac/project/evaluator.go:80]: Failed to get info of project 0 for permission evaluator, error: project 0 not found

Details

TitleReferenceAuthorSource BranchDest Branch
quota: show an error if project does not exist yetrepos/cloud/toolforge/builds-api!77sstefanovaslavina/fix-quotamain
Customize query in GitLab

Related Objects
Search...

Event Timeline

taavi created this task.Dec 19 2023, 1:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 19 2023, 1:48 PM
taavi mentioned this in T341068: Add `toolforge build quota` command.Dec 19 2023, 1:48 PM
taavi updated the task description. (Show Details)
taavi changed the subtype of this task from "Task" to "Bug Report".
Slst2020 claimed this task.Jan 2 2024, 12:51 PM
Slst2020 edited projects, added Toolforge (Toolforge iteration 02); removed Toolforge Build Service.
Slst2020 changed the task status from Open to In Progress.Jan 4 2024, 9:58 AM
Slst2020 moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 02) board.
taavi added a project: Toolforge Build Service.Jan 9 2024, 2:20 PM
Slst2020 changed the task status from In Progress to Open.Jan 9 2024, 2:47 PM
Slst2020 moved this task from In Progress to Next Up on the Toolforge (Toolforge iteration 02) board.
dcaro edited projects, added Toolforge (Toolforge iteration 03); removed Toolforge (Toolforge iteration 02).Jan 9 2024, 3:29 PM
dcaro edited projects, added Toolforge (Toolforge iteration 04); removed Toolforge (Toolforge iteration 03).Jan 24 2024, 9:18 AM
Slst2020 changed the task status from Open to In Progress.Jan 25 2024, 1:41 PM
Slst2020 moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 04) board.
dcaro edited projects, added Toolforge (Toolforge iteration 05); removed Toolforge (Toolforge iteration 04).Feb 6 2024, 5:43 PM
dcaro moved this task from Next Up to In Progress on the Toolforge (Toolforge iteration 05) board.
dcaro triaged this task as Medium priority.Feb 7 2024, 10:12 AM
Slst2020 closed this task as Resolved.Feb 12 2024, 10:54 AM
Slst2020 moved this task from In Progress to Done on the Toolforge (Toolforge iteration 05) board.
taavi added a comment.Feb 12 2024, 10:57 AM

@Slst2020 this does not seem resolved to me? I can still reproduce the issue and there are no patches attached to this task.

CodeReviewBot added a comment.Feb 12 2024, 11:14 AM

sstefanova updated https://gitlab.wikimedia.org/repos/cloud/toolforge/builds-api/-/merge_requests/77

quota: show an error if project does not exist yet

Slst2020 added a comment.Feb 12 2024, 11:18 AM
In T353701#9533076, @taavi wrote:

@Slst2020 this does not seem resolved to me? I can still reproduce the issue and there are no patches attached to this task.

I forgot linking the Phab ticket in the MR. That's fixed now.

tools.nodejs-flask-buildpack-sample@tools-sgebastion-10:~$ toolforge build quota
BuildClientError: Error getting quota from Harbor: Quota cannot be displayed because no builds have run yet
Please report this issue to the Toolforge admins if it persists: https://w.wiki/6Zuu

This is temporary fix improving the error message; when the upstream harbor robot account permissions are fixed, we can display the quota as unused. Right now, we can't retrieve the default project quota because neither the maintain-harbor user nor the robot accounts have the necessary permissions.

taavi added a comment.Feb 12 2024, 11:19 AM

Ok, then this task should be stalled and have the robot account permissions task added as a subtask, instead of being marked as Resolved.

Slst2020 reopened this task as Stalled.Feb 12 2024, 11:20 AM
Slst2020 moved this task from Done to Blocked/Paused on the Toolforge (Toolforge iteration 05) board.
Slst2020 added a subtask: T354507: [harbor] upgrade to 2.10.1.
dcaro edited projects, added Toolforge (Toolforge iteration 06); removed Toolforge (Toolforge iteration 05).Feb 21 2024, 10:10 AM
dcaro moved this task from Next Up to Blocked/Paused on the Toolforge (Toolforge iteration 06) board.
dcaro removed a project: Toolforge Build Service.Mar 5 2024, 1:13 PM
dcaro renamed this task from `build quota` fails if tool has no builds to [builds-cli,builds-api] `build quota` fails if tool has no builds.Mar 5 2024, 3:57 PM
dcaro edited projects, added Toolforge (Toolforge iteration 07); removed Toolforge (Toolforge iteration 06).Mar 5 2024, 5:12 PM
dcaro moved this task from Next Up to Blocked/Paused on the Toolforge (Toolforge iteration 07) board.
Slst2020 changed the status of subtask T354507: [harbor] upgrade to 2.10.1 from Stalled to Open.Mar 19 2024, 7:22 AM
Slst2020 changed the status of subtask T354507: [harbor] upgrade to 2.10.1 from Open to In Progress.Wed, Apr 3, 8:29 AM
Slst2020 changed the task status from Stalled to Open.Wed, Apr 3, 12:03 PM
Slst2020 moved this task from Blocked/Paused to Next Up on the Toolforge (Toolforge iteration 07) board.
Slst2020 added a subtask: T361698: [maintain-harbor] Have maintain-harbor use a robot account.Wed, Apr 3, 12:39 PM
dcaro edited projects, added Toolforge (Toolforge iteration 08); removed Toolforge (Toolforge iteration 07).Wed, Apr 3, 4:16 PM
Slst2020 closed subtask T354507: [harbor] upgrade to 2.10.1 as Resolved.Fri, Apr 5, 12:50 PM
dcaro changed the task status from Open to Stalled.Tue, Apr 16, 2:09 PM
dcaro moved this task from Next Up to Blocked/Paused on the Toolforge (Toolforge iteration 08) board.
dcaro edited projects, added Toolforge (Toolforge iteration 09); removed Toolforge (Toolforge iteration 08).Wed, Apr 17, 7:48 AM
dcaro moved this task from Next Up to Blocked/Paused on the Toolforge (Toolforge iteration 09) board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL