Page MenuHomePhabricator

Long collapsed TOCs can have the bottom cut off
Open, MediumPublic

Description

Description

Raised as an issue here: https://phabricator.wikimedia.org/T352930#9413982

Reprod:

Screenshot 2023-12-19 at 11.50.17 AM.png (1×1 px, 240 KB)

Screenshot 2023-12-19 at 11.50.24 AM.png (1×864 px, 257 KB)

Developer notes

This is happening because the styles for the dropdown max height are based off the full window height, but when the dropdown is in the page title at the top of the viewport, the header and banner will push the dropdown down a bit. We could account for this by reducing the height of the dropdown when its in the page title, but this would likely need JS to be completely accurate given the variable height of banners

Event Timeline

Change 981343 had a related patch set uploaded (by Jdlrobson; author: Jdrewniak):

[mediawiki/skins/Vector@master] Fix dropdown ToC not scrollable

https://gerrit.wikimedia.org/r/981343

Change 981343 abandoned by Jdrewniak:

[mediawiki/skins/Vector@master] Fix dropdown ToC not scrollable

Reason:

Abandoning after the zebra merge. A agree it doesn't really fix the issue, I think we will need a max-height, but probably a combination of vh and a static px value (however far from the top of the page the toc button is).

https://gerrit.wikimedia.org/r/981343