Special:ActiveUsers page duplicates user's edits when searching two user groups they are in
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Wilf233
	Dec 22 2023, 5:00 AM

Description

If a user belongs to two user groups, its number of edits will double in Special:ActiveUsers when both of its user groups are searched.

Steps to replicate the issue & What happens:

Go to Special:ActiveUsers.
Tick "Bureaucrats" in "Display users belonging to groups:"
- You will find that a user "28bytes" has 83 actions.
However, when you tick both "Bureaucrats" and "Administrators":
- You will find that he has 166 actions instead, which doubles.

What should have happened instead?:

The action count should not be duplicated.

Software version:

MediaWiki: 1.42.0-wmf.10 ( 3e07889 )

Other information:

Details

Subject	Repo	Branch	Lines +/-
ActiveUsersPager: Count actions only once	mediawiki/core	REL1_40	+1 -1
ActiveUsersPager: Count actions only once	mediawiki/core	REL1_41	+1 -1
ActiveUsersPager: Count actions only once	mediawiki/core	REL1_39	+1 -1
ActiveUsersPager: Count actions only once	mediawiki/core	master	+1 -1

Customize query in gerrit

Related Objects

Mentioned Here: rMW3e07889c706c: Merge "Inline once-called short private methods to its caller, part 1"

Event Timeline

Wilf233 created this task.Dec 22 2023, 5:00 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 22 2023, 5:00 AM

Wilf233 updated the task description. (Show Details)Dec 22 2023, 5:13 AM

Wilf233 renamed this task from Wrong edit number to Wrong number of actions in ActiveUser Page.Dec 22 2023, 5:22 AM

Wilf233 updated the task description. (Show Details)

Wilf233 updated the task description. (Show Details)Dec 22 2023, 5:35 AM

Winston_Sung added a project: MediaWiki-Special-pages.Dec 22 2023, 5:35 AM

Winston_Sung updated the task description. (Show Details)Dec 22 2023, 5:40 AM

Wilf233 updated the task description. (Show Details)Dec 22 2023, 5:44 AM

Wilf233 updated the task description. (Show Details)

@Wilf233: Thanks for reporting this. For future reference, please use the bug report form (linked from the top of the task creation page) to create a bug report, and fill in the sections in the template. Thanks.

Winston_Sung updated the task description. (Show Details)Dec 22 2023, 6:39 AM

Change 985356 had a related patch set uploaded (by Matěj Suchánek; author: Matěj Suchánek):

[mediawiki/core@master] ActiveUsersPager: Count actions only once

https://gerrit.wikimedia.org/r/985356

gerritbot added a project: Patch-For-Review.Dec 23 2023, 6:29 PM

Change 985356 merged by jenkins-bot:

[mediawiki/core@master] ActiveUsersPager: Count actions only once

https://gerrit.wikimedia.org/r/985356

Change 985386 had a related patch set uploaded (by Anterdc99; author: Matěj Suchánek):

[mediawiki/core@REL1_39] ActiveUsersPager: Count actions only once

https://gerrit.wikimedia.org/r/985386

Change 985387 had a related patch set uploaded (by Anterdc99; author: Matěj Suchánek):