Most folders in FlaggedRevs extension not showing up in PHP code coverage report
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Novem_Linguae
	Dec 29 2023, 11:36 AM

Description

Steps to replicate the issue (include links if applicable):

Visit https://doc.wikimedia.org/cover-extensions/FlaggedRevs/index.html

What happens?:

only /maintenance/ folder is included in PHP code coverage report

What should have happened instead?:

should also include
- /api/
- /backend/
- /business/
- /frontend/
- /rest/
- /scribunto/
- FlaggedRevsSetup.php (in the root folder)

Software version (skip for WMF-hosted wikis like Wikipedia):

Other information (browser name/version, screenshots, etc.):

the fix is either to...
- patch the code coverage report generator to include these folders
- or move these folders into a folder called /includes/, and then very carefully fix everything this breaks. this may require edits to extension.json, or to documentation on MediaWiki wiki, etc.

Details

	Subject	Repo	Branch	Lines +/-
	Move files into includes folder	mediawiki/extensions/FlaggedRevs	master	+60 -67

Customize query in gerrit

Event Timeline

Novem_Linguae created this task.Dec 29 2023, 11:36 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptDec 29 2023, 11:36 AM

patch the code coverage report generator to include these folders

In theory, a custom phpunit config file could do this...

Change 986822 had a related patch set uploaded (by Reedy; author: Reedy):

[mediawiki/extensions/FlaggedRevs@master] Move files into includes folder

https://gerrit.wikimedia.org/r/986822

gerritbot added a project: Patch-For-Review.Jan 1 2024, 4:28 PM

16:31:49 +-------------------------------------------------+-------+--------+
16:31:49 | Filename                                        | Old % | New %  |
16:31:49 +-------------------------------------------------+-------+--------+
16:31:49 | includes/backend/FRInclusionManager.php         | 0     |  78.00 |
16:31:49 | includes/backend/FRUserCounters.php             | 0     |  68.00 |
16:31:49 | includes/backend/FlaggableWikiPage.php          | 0     |  25.00 |
16:31:49 | includes/backend/FlaggedRevision.php            | 0     |  15.00 |
16:31:49 | includes/backend/FlaggedRevs.php                | 0     |  23.00 |
16:31:49 | includes/backend/hook/FlaggedRevsHookRunner.php | 0     | 100.00 |
16:31:49 | includes/rest/DiffHeaderHandler.php             | 0     |  90.00 |
16:31:49 | includes/rest/ReviewHandler.php                 | 0     |  93.00 |
16:31:49 +-------------------------------------------------+-------+--------+

Reedy updated the task description. (Show Details)Jan 1 2024, 4:37 PM

Change 986822 merged by jenkins-bot:

[mediawiki/extensions/FlaggedRevs@master] Move files into includes folder

https://gerrit.wikimedia.org/r/986822

Screenshot 2024-01-01 at 17.29.38.png (618×2 px, 158 KB)

Screenshot 2024-01-01 at 17.29.42.png (391×2 px, 85 KB)

Maintenance_bot removed a project: Patch-For-Review.Jan 1 2024, 5:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.12; 2024-01-02).Jan 1 2024, 6:00 PM

	F41648062: Screenshot 2024-01-01 at 17.29.42.png
	Jan 1 2024, 5:30 PM

	F41648063: Screenshot 2024-01-01 at 17.29.38.png
	Jan 1 2024, 5:30 PM

Most folders in FlaggedRevs extension not showing up in PHP code coverage reportClosed, ResolvedPublicBUG REPORTActions

Description

Details

Event Timeline

Most folders in FlaggedRevs extension not showing up in PHP code coverage report
Closed, ResolvedPublicBUG REPORT
Actions