config.json
Closed, ResolvedPublicBUG REPORT
Actions

Assigned To

Authored By

	Samwilson
	Jan 2 2024, 8:14 AM

Description

Steps to replicate the issue (include links if applicable):

Navigate to Special:EditRecovery, e.g. https://test.wikipedia.org/wiki/Special:EditRecovery
Open the browser's JS console

What happens?:

The following error is shown:

Error: Cannot require undefined file resources/src/mediawiki.editRecovery/config.json
    require startup.js:1011
    js storage.js:5
    require startup.js:1018
    setup SpecialEditRecovery.vue:6

And no list of saved edits is shown.

What should have happened instead?:

No error, and a correct list of stored edit data.

Software version (skip for WMF-hosted wikis like Wikipedia):

MediaWiki 861fa05cc7dc3e1fbfd33db9f0872b9884b56a86

Other information (browser name/version, screenshots, etc.):

Details

Subject	Repo	Branch	Lines +/-
Edit Recovery: Remove unused addJsConfigVars from SpecialEditRecovery.php	mediawiki/core	master	+0 -6
Edit Recovery: Add config.json to special page and postEdit	mediawiki/core	wmf/1.42.0-wmf.12	+10 -1
Edit Recovery: Add config.json to special page and postEdit	mediawiki/core	master	+10 -1
Add config.json as a dependency to all editRecovery modules using storage.js	mediawiki/core	master	+8 -0

Customize query in gerrit

Related Objects

Mentioned Here: rMW861fa05cc7dc: Change DatabaseBlock::TYPE_AUTO to Block::TYPE_AUTO in addUserWarnings

Event Timeline

Samwilson created this task.Jan 2 2024, 8:14 AM

Restricted Application added a project: Community-Tech. · View Herald TranscriptJan 2 2024, 8:14 AM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change 987034 had a related patch set uploaded (by Sohom Datta; author: Sohom Datta):

[mediawiki/core@master] Add config.json as a dependency to all editRecovery modules using storage.js

https://gerrit.wikimedia.org/r/987034

Change 987035 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: Make config.json also available to the special page

https://gerrit.wikimedia.org/r/987035

Change 987034 abandoned by Sohom Datta:

[mediawiki/core@master] Add config.json as a dependency to all editRecovery modules using storage.js

Reason:

https://gerrit.wikimedia.org/r/987034

Change 987035 merged by jenkins-bot:

[mediawiki/core@master] Edit Recovery: Add config.json to special page and postEdit

https://gerrit.wikimedia.org/r/987035

Maintenance_bot removed a project: Patch-For-Review.Jan 2 2024, 12:30 PM

ReleaseTaggerBot added a project: MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 2 2024, 1:00 PM

@Samwilson Should the addJsConfigVars( 'wgEditRecoveryExpiry',… ) code on on SpecialEditRecovery.php be removed, or is that still needed/used for something else?

Change 986657 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@wmf/1.42.0-wmf.12] Edit Recovery: Add config.json to special page and postEdit

https://gerrit.wikimedia.org/r/986657

gerritbot added a project: Patch-For-Review.Jan 3 2024, 1:43 AM

Change 987210 had a related patch set uploaded (by Samwilson; author: Samwilson):

[mediawiki/core@master] Edit Recovery: Remove unused addJsConfigVars from SpecialEditRecovery.php

https://gerrit.wikimedia.org/r/987210

Oops, yes good point! Removing it now.

Samwilson claimed this task.Jan 3 2024, 2:51 AM

Samwilson edited projects, added Community-Tech (CommTech-Kanban); removed Community-Tech.

Change 986657 merged by jenkins-bot:

[mediawiki/core@wmf/1.42.0-wmf.12] Edit Recovery: Add config.json to special page and postEdit

https://gerrit.wikimedia.org/r/986657

ReleaseTaggerBot edited projects, added MW-1.42-notes (1.42.0-wmf.12; 2024-01-02); removed MW-1.42-notes (1.42.0-wmf.13; 2024-01-09 ).Jan 3 2024, 5:00 AM

Samwilson closed this task as Resolved.Jan 3 2024, 11:48 AM

Samwilson moved this task from Ready 🎬 to Done 🏁 on the Community-Tech (CommTech-Kanban) board.

Change 987210 merged by jenkins-bot: