Page MenuHomePhabricator
Create Task
Maniphest T354585

Tidy up our subscribe-links code on the civi side to make change easy
Closed, ResolvedPublic
Actions

Description

I've been digging a little bit & there are things being done in too many places & wrong places - we want to make it so that the only place is in an extension and such that swapping is easy

Note this shows tests that pass through the relevant code

https://integration.wikimedia.org/ci/job/wikimedia-fundraising-civicrm-bullseye-docker/1134/console

Details

SubjectRepoBranchLines +/-
Remove last remnants of the old unsubscribe_link codewikimedia/fundraising/crmmaster+0 -16
Stop passing unsubscribe_link through from test formwikimedia/fundraising/crmmaster+0 -2
Do not calculate unsubscribe_link in RecurringQueueConsumerwikimedia/fundraising/crmmaster+2 -4
Move the ThankYou::send functionality out of drupal moduleswikimedia/fundraising/crmmaster+185 -111
Switch WMFTokens to use the apiwikimedia/fundraising/crmmaster+5 -1
Move unsubscribe link generation to a traitwikimedia/fundraising/crmmaster+36 -26
Switch ThankYou workflow template to use the new unsubscribe apiwikimedia/fundraising/crmmaster+6 -7
Add api to get unsubscribe linkswikimedia/fundraising/crmmaster+178 -0
Customize query in gerrit

Related Objects
Search...

Event Timeline

Eileenmcnaughton created this task.Jan 9 2024, 4:05 AM
gerritbot added a comment.Jan 9 2024, 4:40 AM

Change 988749 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Add api to get unsubscribe links

https://gerrit.wikimedia.org/r/988749

gerritbot added a project: Patch-For-Review.Jan 9 2024, 4:40 AM

Change 988750 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Switch ThankYou workflow template to use the new unsubscribe api

https://gerrit.wikimedia.org/r/988750

gerritbot added a comment.Jan 9 2024, 4:40 AM

Change 988751 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move unsubscribe link generation to a trait

https://gerrit.wikimedia.org/r/988751

gerritbot added a comment.Jan 9 2024, 4:40 AM

Change 988752 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Switch WMFTokens to use the api

https://gerrit.wikimedia.org/r/988752

gerritbot added a comment.Jan 9 2024, 5:05 AM

Change 988753 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Move the ThankYou::send functionality out of drupal modules

https://gerrit.wikimedia.org/r/988753

Eileenmcnaughton updated the task description. (Show Details)Jan 9 2024, 5:27 AM
gerritbot added a comment.Jan 9 2024, 5:36 AM

Change 988757 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Do not calculate unsubscribe_link in RecurringQueueConsumer

https://gerrit.wikimedia.org/r/988757

gerritbot added a comment.Jan 9 2024, 5:36 AM

Change 988758 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Stop passing unsubscribe_link through from test form

https://gerrit.wikimedia.org/r/988758

gerritbot added a comment.Jan 9 2024, 5:36 AM

Change 988759 had a related patch set uploaded (by Eileen; author: Eileen):

[wikimedia/fundraising/crm@master] Remove last remnants of the old unsubscribe_link code

https://gerrit.wikimedia.org/r/988759

XenoRyet moved this task from Triage to Current Sprint on the Fundraising-Backlog board.Jan 9 2024, 8:34 PM
jgleeson moved this task from Backlog to Being Reviewed on the Fundraising Sprint - Yesterday (UTC) board.Jan 10 2024, 2:42 PM
gerritbot added a comment.Jan 11 2024, 11:57 AM

Change 988749 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Add api to get unsubscribe links

https://gerrit.wikimedia.org/r/988749

gerritbot added a comment.Jan 11 2024, 11:57 AM

Change 988750 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Switch ThankYou workflow template to use the new unsubscribe api

https://gerrit.wikimedia.org/r/988750

gerritbot added a comment.Jan 11 2024, 11:59 AM

Change 988751 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move unsubscribe link generation to a trait

https://gerrit.wikimedia.org/r/988751

gerritbot added a comment.Jan 11 2024, 11:59 AM

Change 988752 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Switch WMFTokens to use the api

https://gerrit.wikimedia.org/r/988752

gerritbot added a comment.Jan 11 2024, 11:59 AM

Change 988753 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Move the ThankYou::send functionality out of drupal modules

https://gerrit.wikimedia.org/r/988753

AKanji-WMF edited projects, added Fundraising Spring - anybodyKnowWhatThisDoes(); removed Fundraising Sprint - Yesterday (UTC).Jan 17 2024, 3:51 AM
AnnWF moved this task from Backlog to Being Reviewed on the Fundraising Spring - anybodyKnowWhatThisDoes() board.Jan 17 2024, 8:18 PM
gerritbot added a comment.Jan 22 2024, 1:50 PM

Change 988757 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Do not calculate unsubscribe_link in RecurringQueueConsumer

https://gerrit.wikimedia.org/r/988757

gerritbot added a comment.Jan 22 2024, 1:50 PM

Change 988758 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Stop passing unsubscribe_link through from test form

https://gerrit.wikimedia.org/r/988758

gerritbot added a comment.Jan 22 2024, 1:50 PM

Change 988759 merged by jenkins-bot:

[wikimedia/fundraising/crm@master] Remove last remnants of the old unsubscribe_link code

https://gerrit.wikimedia.org/r/988759

Maintenance_bot removed a project: Patch-For-Review.Jan 22 2024, 2:30 PM
AKanji-WMF edited projects, added Fundraising Sprint: brb(); removed Fundraising Spring - anybodyKnowWhatThisDoes().Jan 30 2024, 9:09 PM
Eileenmcnaughton claimed this task.Jan 31 2024, 3:50 AM
Eileenmcnaughton moved this task from Backlog to Done on the Fundraising Sprint: brb() board.
Eileenmcnaughton edited projects, added Fundraising Spring - anybodyKnowWhatThisDoes(); removed Fundraising Sprint: brb().
Eileenmcnaughton set Final Story Points to 4.
AKanji-WMF edited projects, added Fundraising Sprint: brb(); removed Fundraising Spring - anybodyKnowWhatThisDoes().Feb 2 2024, 9:13 PM
AKanji-WMF moved this task from Done to Being Reviewed on the Fundraising Sprint: brb() board.
Eileenmcnaughton moved this task from Being Reviewed to Done on the Fundraising Sprint: brb() board.Feb 5 2024, 8:39 PM
XenoRyet closed this task as Resolved.Feb 12 2024, 8:23 PM
XenoRyet closed subtask T354586: Determine if we need to have 1-click unsubscribes on our thank you etc emails as Resolved.Mar 11 2024, 7:15 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits